Move Home Panel CTA to Bottom Sheet

[malmstein]

Task/Issue URL: https://app.asana.com/0/1174433894299346/1207561426611562/f

Description

Migrates HomeCTA to use PromoBottomSheet
We are also removing all the code to display Surveys in that CTA

Steps to test this PR

Widget CTA Orientation

• Fresh install, finish onboarding and create a New Tab
• Verify that Home Widget Bottom Sheet is visible
• Rotate the device and verify that Bottom Sheet is still visible

Widget CTA Logic

• Fresh install, finish onboarding and create a New Tab
• Verify that Home Widget Bottom Sheet is visible
• Dismiss it by tapping anywhere in the screen
• Close the app and open it again
• Verify that Bottom Sheet doesn’t appear again

Survey CTA Removal

• Create sandbox survey
• Change endpoint to trigger surveys from sandbox
• Fresh install
• Verify that Survey CTA is not visible
• Verify app works as expected

[malmstein]

• Move Home Panel CTA to Bottom Sheet #4646 👈
• develop

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @malmstein and the rest of your teammates on Graphite

[nalcalag]

@malmstein if I rotate the screen following the steps to test, it crashes.
When fun renderHomeCta() is called after onConfigurationChanged(), we get the exception lateinit property ctaBottomSheet has not been initialised.
Ping me if you need anything.

[nalcalag]

@malmstein I tested this and works as expected 👍 However, I have a couple of concerns with the change:

1. When the BottomSheet is displayed, the rest of the browser is greyed out, and users can't interact with the browser until they dismiss the CTA. Therefore, I think we should change it as it was before in terms of user experience.
2. The CTA display should be handled from the Cta.kt class instead of directly from the BrowserTabFragment for consistency and to extract code from the Fragment. We can create a new interface BottomSheetCta which would have buildCta() and return the instance of the PromoBottomSheetDialog. Then make HomePanelCta to implement this new interface instead ViewCta. (Just an idea)

I'll include this comment in Asana too so we can discuss it there.

[nalcalag]

Tested and works as expected ✅

There were a couple of comments from the previous review:

1. (NIT) add description to the new method in the PromoBottomSheetDialog API
2. (not a blocker) Move logic to display the PromoBottomSheet to the Cta.kt instead the BrowserTabFragment

[malmstein]

Thanks @nalcalag !