Add user-journey completion check for importing passwords via desktop sync

[CDRussell]

Task/Issue URL: https://app.asana.com/0/1203822806345703/1207149249611733/f

Description

Steps to test this PR

Suggest logcat filter: message~:"user-journey" message~:"Pixel sent: .*autofill"

Testing the "immediate success" flow

• Fresh install
• Visit Passwords screen, then tap the Import Passwords button
• Verify you see Starting user-journey success clock for import passwords screen in the logs
• Verify you see m_autofill_logins_import_user_journey_started in the logs
• Tap Sync with Desktop button
• Enable sync, and sync with a desktop device
• Go back to the "Import Passwords" screen. verify logs contain m_autofill_logins_import_success

Testing the timed out failure flow

• Fresh install
• Visit Passwords screen, then tap the Import Passwords button
• Set the system date to >= 3 days into the future
• Return to the app. Verify the logs contain m_autofill_logins_import_failure

Testing the delayed success flow

• Fresh install
• Visit Passwords screen, then tap the Import Passwords button
• Hit back, and return to the browser activity
• Go to Settings -> Sync & Backup and setup syncing with a desktop device
• Background the app and restore it.
• Verify log contains m_autofill_logins_import_success

Restarting the clock

• Fresh install
• Visit Passwords screen, then tap the Import Passwords button
• Verify the logs contain Starting user-journey success clock for import passwords screen
• Hit back to return to passwords screen
• Tap Import Passwords button again
• Verify logs contain Restarting user-journey success clock for import passwords screen
• Verify logs contain m_autofill_logins_import_user_journey_restarted
• Background the app and restore it. Verify logs indicate 48h clock was restarted when you re-entered the import passwords screen, by looking at the time remaining

[CDRussell]

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

• Add user-journey completion check for importing passwords via desktop sync #4698 👈
• Pixels for importing passwords via desktop sync #4692
• Add new screens with instructions for importing passwords via sync #4687
• develop

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @CDRussell and the rest of your teammates on Graphite

[cmonfortep]

LGTM

Just sharing a proposal for reorganizing the logic a bit, to keep the business logic together and viewmodel simpler.

[cmonfortep]

Wouldn't be better to move all logic related to user journey checks into it's own class?

I see few benefits:

• ViewModel will be simplified of all logic about sync journey checks, which can be extracted. We can move all that business logic and just keep UI logic here.
• Dependencies can also be simplified: ViewModel has journey detecting logic which relies on ImportPasswordsViaDesktopSyncDataStore and UserJourneyEndRecorder and DeviceSyncState. UserJourneyEndRecoder on a different class (with dependency to ImportPasswordsViaDesktopSyncDataStore).

I think the flow is easier if we just do: viewModel -> SyncImportUserJourney -> Business logic related to tracking journey

[CDRussell]

Yeah, I think that is a good suggestion. I am going to do that as a follow-up as I don't think it's a blocker, tracking as Autofill: extract more of the business logic around importing passwords via desktop to its own class

[cmonfortep]

Interesting. Do we need to create modules if we rely on DS?

[CDRussell]

Not strictly sure if needed, tbh; I was keeping it consistent with the other DS usage we have.

[cmonfortep]

"Background the app and restore it. Verify logs indicate 48h clock was restarted when you re-entered the import passwords screen, by looking at the time remaining"

This is the only step that didn't work for me.

[CDRussell]

"Background the app and restore it. Verify logs indicate 48h clock was restarted when you re-entered the import passwords screen, by looking at the time remaining"

This is the only step that didn't work for me.

I'm guessing I know why, and the instructions could have been clearer. Simply returning to the screen won't reset the clock. You have to come in with the Activity being created (basically, through the Import Passwords button/menu again) but doing this won't print the time remaining.

So you have to use the import passwords button again and flip it background/foreground to see the timer back up at 48h. but anyway, was just an extra check and i've ensured it's all good.