Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add delegated autofill isEnabled check and pixel params #130

Merged
merged 9 commits into from Aug 12, 2022
Merged

Add delegated autofill isEnabled check and pixel params #130

merged 9 commits into from Aug 12, 2022

Conversation

THISISDINOSAUR
Copy link
Contributor

@THISISDINOSAUR THISISDINOSAUR commented Aug 11, 2022 •
edited

Please review the release process for BrowserServicesKit here.

Required:

Task/Issue URL: https://app.asana.com/0/0/1202498365125439/f
iOS PR: duckduckgo/iOS#1269
macOS PR: https://github.com/more-duckduckgo-org/macos-browser/pull/683
What kind of version bump will this require?: Major

Optional:

Tech Design URL:
CC:

Description:

  • Adds a check for autofill actually being enabled on the 'didRequestAutoFillInitDataForDomain" method, since if it's not, we shouldn't be trying to create a secure vault

macOS should be essentially no change, iOS is where the business is happening

Steps to test this PR:

  1. See macOS and iOS Pro for individual testing

OS Testing:

  • iOS 13
  • iOS 14
  • iOS 15
  • macOS 10.15
  • macOS 11
Internal references:

Software Engineering Expectations
Technical Design Template

@THISISDINOSAUR THISISDINOSAUR changed the title Elle/move secure vault to group Add delegated autofill isEnabled check and pixel params Aug 11, 2022
@Bunn Bunn self-assigned this Aug 11, 2022
Bunn
Bunn approved these changes Aug 11, 2022
View reviewed changes
Copy link
Contributor

@Bunn Bunn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

macOS and OS tested.
LGTM ✅

@Bunn Bunn assigned THISISDINOSAUR and unassigned Bunn Aug 11, 2022
@THISISDINOSAUR THISISDINOSAUR merged commit 05ed8ae into main Aug 12, 2022
@THISISDINOSAUR THISISDINOSAUR deleted the elle/move-secure-vault-to-group branch August 12, 2022 11:38
samsymons added a commit that referenced this pull request Aug 18, 2022
@samsymons
Merge branch 'main' into sam/remove-email-waitlist
1e8a1df 
* main:
  Add delegated autofill isEnabled check and pixel params (#130)
  Update to GRDB 1.2.0 (#119)
  Fire pixel when autoprompt is dismissed (#124)
  Tweaks and bug fixes for #126 (#128)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Bunn Bunn Bunn approved these changes

@brindy brindy Awaiting requested review from brindy

@bwaresiak bwaresiak Awaiting requested review from bwaresiak

@mallexxx mallexxx Awaiting requested review from mallexxx

@tomasstrba tomasstrba Awaiting requested review from tomasstrba

@samsymons samsymons Awaiting requested review from samsymons

Assignees

@THISISDINOSAUR THISISDINOSAUR

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@THISISDINOSAUR @Bunn