Fix rules for tumblr.com, onlyfans, canva.com, cookie-script #395
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
muodov
commented
Mar 15, 2024
muodov
commented
- https://app.asana.com/0/1203268166580279/1206801782393473/f
- https://app.asana.com/0/1203268166580279/1206849682571983/f
- https://app.asana.com/0/1203268166580279/1206850828892928/f
- https://app.asana.com/0/1203268166580279/1206747922199698/f
muodov
added
minor
sammacbeth
requested changes
Mar 19, 2024
rules/autoconsent/cookie-script.json
Outdated
| "optOut": [ | ||
| { | ||
| "if": { "exists": "#cookiescript_reject" }, | ||
| "then": [{" click": "#cookiescript_reject" }], |
There was a problem hiding this comment.
Suggested change
| "then": [{" click": "#cookiescript_reject" }], | |
| "then": [{"click": "#cookiescript_reject" }], |
There was a problem hiding this comment.
I also found a glitch on https://trauer.hna.de/, where the banner doesn't get properly hidden, probably because we're clicking it too fast. Adding a { "wait": 100 } step fixed it.
There was a problem hiding this comment.
Thanks Sam, good catches!
| @@ -11,7 +11,8 @@ | |||
| "click": "div.b-cookies-informer__nav > button:nth-child(1)" | |||
| }, | |||
| { | |||
| "click": "div.b-cookies-informer__switchers > div:nth-child(2) > div[at-attr=\"checkbox\"] > span.b-input-radio__container > input[type=\"checkbox\"]" | |||
There was a problem hiding this comment.
Should we add a urlPattern on this rule? In the coverage data it only runs on onlyfans.com.
sammacbeth
approved these changes
Mar 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.