Fix Klaro rule (wogibtswas.de, www.suedtirol.com) #404
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
muodov
reviewed
Mar 26, 2024
lib/cmps/klaro.ts
Outdated
| this.settingsOpen = true; | ||
| } | ||
| // open popup via Javascript API | ||
| await this.mainWorldEval("EVAL_KLARO_2") |
There was a problem hiding this comment.
- should we change optIn() too and remove
settingsOpen? - if API is available, does it allow to reject cookies without clicking at all?
muodov
approved these changes
Apr 12, 2024
muodov
changed the title
This was referenced Apr 12, 2024
aitorvs
pushed a commit
to duckduckgo/Android
that referenced
this pull request
Apr 25, 2024
Task/Issue URL: https://app.asana.com/0/1207065820015495/1207065820015495 Autoconsent Release: https://github.com/duckduckgo/autoconsent/releases/tag/v10.6.1 ## Description Updates Autoconsent to version [v10.6.1](https://github.com/duckduckgo/autoconsent/releases/tag/v10.6.1). ### Autoconsent v10.6.1 release notes #### 🐛 Bug Fix - Fix Klaro rule (wogibtswas.de, www.suedtirol.com) [#404](duckduckgo/autoconsent#404) ([@sammacbeth](https://github.com/sammacbeth)) #### Authors: 1 - Sam Macbeth ([@sammacbeth](https://github.com/sammacbeth)) ## Steps to test This release has been tested during Autoconsent development. You can check the release notes for more information. Co-authored-by: muodov <muodov@users.noreply.github.com> Co-authored-by: Maxim Tsoy <maks.tsoy@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Klaro rule was failing to open the popup on the following sites:
This changes the rule to use the
klaroJS API to open the popup. This seems more robust for the different ways of embedding this.