Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix sibbo rule #423

Merged
merged 1 commit into from
Apr 23, 2024
Merged

Fix sibbo rule #423

merged 1 commit into from
Apr 23, 2024

Conversation

sammacbeth
Copy link
Collaborator

This rule was out of date and not working on any test sites.

See https://app.asana.com/0/1203268166580279/1207137056781932/f

@sammacbeth sammacbeth requested a review from muodov April 23, 2024 09:07
muodov
muodov approved these changes Apr 23, 2024
View reviewed changes
Copy link
Member

@muodov muodov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's ok to merge because it fixes some sites, but some other sites have a paywall, that we should track in #387

@sammacbeth sammacbeth added the patch Increment the patch version when merged label Apr 23, 2024
@sammacbeth sammacbeth merged commit 57c36fd into main Apr 23, 2024
7 checks passed
gpanneti pushed a commit to tempest-tech-ltd/autoconsent that referenced this pull request Apr 29, 2024
@sammacbeth @gpanneti
Fix sibbo rule (duckduckgo#423)
4bfd2dd
gpanneti pushed a commit to tempest-tech-ltd/autoconsent that referenced this pull request Apr 29, 2024
@sammacbeth @gpanneti
Fix sibbo rule (duckduckgo#423)
42d9cd9
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@muodov muodov muodov approved these changes

Assignees
No one assigned
Labels
patch Increment the patch version when merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@sammacbeth @muodov