This repository has been archived by the owner on Jan 10, 2019. It is now read-only.
broken site button #153
Open
broken site button #153
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
laurengarcia
suggested changes
Jul 20, 2017
| @@ -1,5 +1,6 @@ | |||
| const bel = require('bel'); | |||
| const toggleButton = require('./shared/toggle-button'); | |||
| const Button = require('./shared/button'); | |||
There was a problem hiding this comment.
shared/button is a function not a constructor, so it should be const button not const Button.
| $popup__height: 505px; | ||
| $popup__height--moz: 520px; | ||
| $popup__height: 540px; | ||
| $popup__height--moz: 540px; |
There was a problem hiding this comment.
Notice that originally the heights across browsers were different and now they are the same. Did you verify that the height was correct in FF and Chrome? I would think that FF would be taller.
| margin:0; | ||
| padding:0; | ||
| } | ||
| } |
There was a problem hiding this comment.
Please add a new blank line between this and next line, and add a space between properties and values above.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reviewer:
Description:
Added a report broken site that links to a survey.
Steps to test this PR:
Automated tests:
Reviewer Checklist:
PR Author Checklist: