DBP: first action #843
Merged
DBP: first action #843
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Current dependencies on/for this PR:
This stack of pull requests is managed by Graphite. |
This was referenced Nov 21, 2023
Merged
muodov
reviewed
Nov 21, 2023
|
@muodov I narrowed some of the types as you suggested - but I don't think there's anything else blocking here? |
|
@shakyShane no blockers, it looks good. I understand that these scripts will only be run on select pages, right? If so, we can be less worried about webcompat issues in the wild. |
|
@muodov yeah that's correct - these are never going to be enabled for general users. |
muodov
approved these changes
Nov 21, 2023
brianhall
approved these changes
Nov 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://app.asana.com/0/0/1206000767975136/f
Feature Summary
Native platforms will send one of the following instructions, one at a time:
navigateextractclick<- included in this PRexpectationfillFormgetCaptchaInfosolveCaptchaEach of them has a corresponding function that will be executed, and will return either a SuccessResponse or ErrorResponse to native.
The flow looks like this: (taken from the markdown file in the PR)