Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

node 20 support #948

Merged
merged 2 commits into from
Apr 8, 2024
Merged

Conversation

shakyShane
Copy link
Collaborator

@shakyShane shakyShane commented Apr 4, 2024

https://app.asana.com/0/1201614831475344/1206978084282836/f

TL;DR

This PR upgrades the Node.js version used in the GitHub actions workflows from 18 to 20. It also adjusts some test cases.

What changed?

  • The Node.js version in the GitHub actions workflows and the .nvmrc file was updated from 18.x to 20.x.
  • Some tests updated to handle the random IDs we get now because of the newer node version

How to test?

After merging, confirm that the GitHub actions workflows run successfully using the new Node.js version.

Why make this change?

Screenshot 2024-04-04 at 10 48 47 AM

@shakyShane
Copy link
Collaborator Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @shakyShane and the rest of your teammates on Graphite Graphite

@shakyShane shakyShane marked this pull request as ready for review April 4, 2024 09:53
@shakyShane shakyShane force-pushed the 04-04-chore_node_moving_to_node_20 branch from 03a1846 to 85a73a5 Compare April 5, 2024 13:18
@shakyShane shakyShane marked this pull request as draft April 5, 2024 14:05
@shakyShane shakyShane force-pushed the 04-04-chore_node_moving_to_node_20 branch from 85a73a5 to 3fcdabd Compare April 8, 2024 09:30
@shakyShane shakyShane force-pushed the 04-04-chore_node_moving_to_node_20 branch from 3fcdabd to 16483fb Compare April 8, 2024 09:41
@shakyShane shakyShane marked this pull request as ready for review April 8, 2024 09:44
@shakyShane shakyShane changed the title chore(node): moving to node 20 node 20 support Apr 8, 2024
@jonathanKingston jonathanKingston merged commit 5b05a2a into main Apr 8, 2024
4 checks passed
@jonathanKingston jonathanKingston deleted the 04-04-chore_node_moving_to_node_20 branch April 8, 2024 09:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants