Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor "Learn more" link in privacy-options. #1029

Closed
zeraye opened this issue Jan 22, 2022 · 7 comments
Closed

Refactor "Learn more" link in privacy-options. #1029

zeraye opened this issue Jan 22, 2022 · 7 comments

Comments

@zeraye
Copy link

zeraye commented Jan 22, 2022

Description

Learn more link in privacy-options is inline with text.

Steps to Reproduce

  1. Install addon on Firefox.
  2. Click on "Unprotected Sites" in addon menu.

Expected behavior:
screen2

Actual behavior:
screen1

Versions

  • Extension: 2021.9.30
  • Browser: Firefox Developer Edition 97.0b6 (64-bit)
  • OS: Windows

Additional information

Fix is pretty straightforward.
Example fix: https://github.com/Zeraye/duckduckgo-privacy-extension/commit/f1326d659fed80e9378be4f5f2f23e4a66aacec4

@zeraye zeraye closed this as completed Jan 22, 2022
@zeraye zeraye changed the title Refactor Refactor "Learn more" link in privacy-options. Jan 22, 2022
@zeraye zeraye reopened this Jan 22, 2022
@varunmulay22
Copy link

is this an active issue?

@zeraye
Copy link
Author

zeraye commented Mar 6, 2023

Now there is space after dot, so it can count as fix. I prefer not to close issue, but wait for someone from ddg to close it.
image

@imsoumya18
Copy link
Contributor

imsoumya18 commented Aug 9, 2023

I have created PR #2171 to fix this. Please review that.

@imsoumya18
Copy link
Contributor

Please review PR #2171 . It's saying waiting for approval.
@zeraye

@zeraye
Copy link
Author

zeraye commented Aug 10, 2023

I'm not a ddg's developer. According to CONTRIBUTING.md most bug fixes and feature development are handled internally. Thus pull requests from people outside may be not reviewed.

@imsoumya18
Copy link
Contributor

@zeraye I resolved this and my PR #2171 has been merged also. You can close this issue now.

@zeraye
Copy link
Author

zeraye commented Oct 8, 2023

Issue resolved in #2171.

@zeraye zeraye closed this as completed Oct 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants