Skip to content

Commit

Permalink
Update PR template to better match new format used across the org
Browse files Browse the repository at this point in the history
  • Loading branch information
subsymbolic committed Feb 28, 2018
1 parent 8d3c8f9 commit c3d950d
Showing 1 changed file with 9 additions and 18 deletions.
27 changes: 9 additions & 18 deletions .github/PULL_REQUEST_TEMPLATE.md
@@ -1,29 +1,20 @@
<!--
Note: This checklist is a reminder of our shared engineering expectations. Feel free to change it, though reviewer and all items in bold are required.
Note: This checklist is a reminder of our shared engineering expectations. Feel free to change it, although assigning a GitHub reviewer and the items in bold are required.
-->

Reviewer:
Asana:
Task/Issue URL:
Tech Design URL:
CC:

**Description**:


**Steps to test this PR**:
1. <STEP 1>
1.
1.


###### Reviewer Checklist:
- [ ] **Ensure the PR solves the problem**
- [ ] **Review every line of code**
- [ ] **Ensure the PR does no harm by testing the changes thoroughly**
- [ ] **Get help if you're uncomfortable with any of the above!**
- [ ] Determine if there are any quick wins that improve the implementation


###### PR DRI Checklist:
- [ ] Get advice or leverage existing code
- [ ] Agree on technical approach with reviewer (if the changes are nuanced)
- [ ] Ensure that there is a testing strategy (and documented non-automated tests)
- [ ] Ensure there is a documented monitoring strategy (if necessary)
- [ ] Consider systems implications (Database connections, Grafana stats, CPU)
---
###### Internal references:
[Software Engineering Expectations](https://app.asana.com/0/59792373528535/199064865822552)
[Technical Design Template](https://app.asana.com/0/59792373528535/184709971311943)

0 comments on commit c3d950d

Please sign in to comment.