Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Update PR template to better match new format used across the org
- Loading branch information
1 parent
8d3c8f9
commit c3d950d
Showing
1 changed file
with
9 additions
and
18 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,29 +1,20 @@ | ||
<!-- | ||
Note: This checklist is a reminder of our shared engineering expectations. Feel free to change it, though reviewer and all items in bold are required. | ||
Note: This checklist is a reminder of our shared engineering expectations. Feel free to change it, although assigning a GitHub reviewer and the items in bold are required. | ||
--> | ||
|
||
Reviewer: | ||
Asana: | ||
Task/Issue URL: | ||
Tech Design URL: | ||
CC: | ||
|
||
**Description**: | ||
|
||
|
||
**Steps to test this PR**: | ||
1. <STEP 1> | ||
1. | ||
1. | ||
|
||
|
||
###### Reviewer Checklist: | ||
- [ ] **Ensure the PR solves the problem** | ||
- [ ] **Review every line of code** | ||
- [ ] **Ensure the PR does no harm by testing the changes thoroughly** | ||
- [ ] **Get help if you're uncomfortable with any of the above!** | ||
- [ ] Determine if there are any quick wins that improve the implementation | ||
|
||
|
||
###### PR DRI Checklist: | ||
- [ ] Get advice or leverage existing code | ||
- [ ] Agree on technical approach with reviewer (if the changes are nuanced) | ||
- [ ] Ensure that there is a testing strategy (and documented non-automated tests) | ||
- [ ] Ensure there is a documented monitoring strategy (if necessary) | ||
- [ ] Consider systems implications (Database connections, Grafana stats, CPU) | ||
--- | ||
###### Internal references: | ||
[Software Engineering Expectations](https://app.asana.com/0/59792373528535/199064865822552) | ||
[Technical Design Template](https://app.asana.com/0/59792373528535/184709971311943) |