Sanitize location selection against remote locations #2688
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 tasks
graeme
force-pushed
the
graeme/sanitize-location-selection
branch
from
9d68bc7
to
5816933
Compare
github-actions
bot
added
the
bot: not in app board
graeme
force-pushed
the
graeme/sanitize-location-selection
branch
from
5816933
to
e99fdb7
Compare
graeme
removed
the
bot: not in app board
# By bwaresiak (6) and others # Via Bartek Waresiak (1) and others * main: (30 commits) Update VPN support copy (#2894) Settings experiment disabled and new Settings rolled out to all users (#2904) Release 7.122.0-2 (#2909) PrivacyPro terms of service link (#2907) Release 7.122.0-1 (#2906) Fix release branch VPN auth issues (#2903) Disable the autofill survey (#2899) fire RMF message updated notification if we make any change to the store (#2891) Fix maestro config so it runs (#2896) Disable the autofill survey (#2899) Release 7.122.0-0 (#2898) Do not refresh collection view when we are changing the display mode (#2895) Add option to crash the app with exception from debug menu (#2897) Remove default.profraw (#2893) Guard swipe tabs scroll state (#2888) Add debug pixels for data cleanup (#2890) Bump rexml from 3.2.6 to 3.2.8 (#2866) Remove VPN waitlist code (#2795) Privacy Pro Follow ups (#2882) Clean up subscriptionFeature on init (#2880) ... # Conflicts: # DuckDuckGo.xcodeproj/project.pbxproj # DuckDuckGo.xcodeproj/project.xcworkspace/xcshareddata/swiftpm/Package.resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task/Issue URL: https://app.asana.com/0/1203137811378537/1206773442486707/f
BSK: duckduckgo/BrowserServicesKit#764
Description:
The VPN geoswitching logic currently doesn’t handle the case that a location becomes unavailable. We should fall back to the country, if a city isn’t available, or nearest if the country isn’t available.
Steps to test this PR:
NetworkProtectionVPNLocationViewModelto hardcode an extra a location that doesn’t exist and present it on the UI. Try with a country that doesn’t exist as well as a city that doesn’t exist being added to a country that does.Copy Testing:
’rather than’Orientation Testing:
Device Testing:
OS Testing:
Theme Testing:
—
Internal references:
Software Engineering Expectations
Technical Design Template