Reapply "Report Apple Ad attribution using pixel" #2702
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dus7
changed the title
dus7
force-pushed
the
mariusz/reapply-ad-attribution
branch
from
3898d66
to
2b3428a
Compare
dus7
commented
Apr 26, 2024
| @@ -410,6 +411,14 @@ class AppDelegate: UIResponder, UIApplicationDelegate { | |||
| } | |||
| } | |||
|
|
|||
| private func reportAdAttribution() { | |||
| guard AdAttributionPixelReporter.isAdAttributionReportingEnabled else { return } | |||
There was a problem hiding this comment.
I've add flag here so it's easy to flip the switch once needed.
samsymons
approved these changes
Apr 29, 2024
samsymons
added a commit
that referenced
this pull request
Apr 30, 2024
* main: (38 commits) Disable the feedback send button when there’s no text (#2800) Release 7.118.0-0 (#2802) Autofill Settings - Import passwords via sync (#2756) Fix selected VPN location consistency (#2797) Reapply "Report Apple Ad attribution using pixel" (#2702) reapply auto clear fix, clear cookies, load page on link click (#2798) Toggle Connect on Demand when receiving user initiated VPN lifecycle events (#2771) Update BSK to 141.1.1 (#2796) iOS: VPN Metadata Improvements (#2791) Add Internal Page suggestions support (#2784) iOS: Add pixels to track VPN wake and stop attempts (#2785) Fix bug that shows selected tab in strange position in the switcher (#2789) Remove AppTP (#2682) Release 7.117.0-1 (#2794) cherry pick progress bar fix (#2793) fix progress bar missing after cold launch (#2792) Check entitlements before showing VPN screen from notification (#2748) Add parameter allowed encoding to error descriptions (#2781) Update Lottie to 4.4.3 (#2765) Update to fastlane 2.220.0 to fix ad-hoc lane (#2782) ...
ayoy
pushed a commit
that referenced
this pull request
May 8, 2024
Task/Issue URL: https://app.asana.com/0/414235014887631/1207179335148911/f Description: This PR enables the attribution flag added in #2702.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task/Issue URL: https://app.asana.com/0/414235014887631/1206793336468690/f
Description:
Adds a pixel
m.apple-ad-attributionto monitor anonymous install attribution data from Apple. Pixel is sent during launch once per installation.Steps to test this PR:
—
Internal references:
Software Engineering Expectations
Technical Design Template