VPN: Specific TunnelController start failure reporting #2714
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
graeme
force-pushed
the
graeme/add-more-specific-error-to-controller-failure
branch
from
57e4cc5
to
e82f18b
Compare
graeme
force-pushed
the
graeme/add-more-specific-error-to-controller-failure
branch
from
3557a3c
to
6588a90
Compare
diegoreymendez
approved these changes
Apr 12, 2024
| @@ -37,9 +37,24 @@ final class NetworkProtectionTunnelController: TunnelController { | |||
|
|
|||
| // MARK: - Starting & Stopping the VPN | |||
|
|
|||
| enum StartError: LocalizedError { | |||
| case connectionStatusInvalid | |||
| enum StartError: LocalizedError, CustomNSError { | |||
| case startVPNFailed(Error) | ||
| case fetchAuthTokenFailed(Error) | ||
|
|
||
| public static let errorDomain = "com.duckduckgo.NetworkProtectionTunnelController.StartError.domain" |
There was a problem hiding this comment.
Just a note that I believe you can omit this, and the system will fill it in with a nice string.
|
|
||
| public static let errorDomain = "com.duckduckgo.NetworkProtectionTunnelController.StartError.domain" | ||
|
|
||
| public var errorCode: Int { |
There was a problem hiding this comment.
Great to have explicit codes. Thanks :)
Comment on lines
57
to
69
| public var errorUserInfo: [String: Any] { | ||
| switch self { | ||
| case | ||
| .simulateControllerFailureError: | ||
| return [:] | ||
| case | ||
| .loadFromPreferencesFailed(let error), | ||
| .saveToPreferencesFailed(let error), | ||
| .startVPNFailed(let error), | ||
| .fetchAuthTokenFailed(let error): | ||
| return ["NSUnderlyingError": error] | ||
| } | ||
| } |
There was a problem hiding this comment.
Right, my bad I missed this.
| .saveToPreferencesFailed(let error), | ||
| .startVPNFailed(let error), | ||
| .fetchAuthTokenFailed(let error): | ||
| return ["NSUnderlyingError": error] |
There was a problem hiding this comment.
There's a constant NSUnderlyingErrorKey.
diegoreymendez
approved these changes
Apr 12, 2024
samsymons
added a commit
that referenced
this pull request
Apr 15, 2024
# By Daniel Bernal (33) and others # Via Mariusz Śpiewak (5) and others * main: (245 commits) Fix inconsistent bars state when scrolling (#2733) fix tests (#2732) Release 7.115.0-4 (#2729) Fix VPN denial prompt loop (#2728) Small UI Fixes for subscriptions (#2690) SPM updated: SwiftSoup, Lottie, ZIPFoundation (#2724) Release 7.115.0-3 (#2727) VPN: Specific TunnelController start failure reporting (#2714) update bsk dependency (#2725) Subscriptions: Fix thread issue on Subscription Restore (#2719) Manage ‘Stale’ PRs (#2723) maestro: hide dax dialogs if visible and cancel keyboard after fireproof (#2695) Remove timezone offset from the VPN server object (#2701) Reverting accidental push to main (#2718) Add SubscriptionContainerViewModel and Manually hide loader + Pixel (#2687) Release 7.115.0-2 (#2712) soft revert history suggestions (#2711) Bring back accessibility identifiers for onboarding buttons (#2709) BSK release 133.1.0 (#2708) ... # Conflicts: # Core/Pixel.swift
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task/Issue URL: https://app.asana.com/0/414235014887631/1207056623910446/f
Background
We’re seeing a rise in tunnel controller start failures but are lacking which specific function calls to the SDK are causing the failure.
Objective
Add more specific errors that can be sent with the m.netp.controller.start.failure.ios pixel to help with diagnosing the issue.
Steps to test this PR:
Copy Testing:
’rather than'Orientation Testing:
Device Testing:
OS Testing:
Theme Testing:
Internal references:
Software Engineering Expectations
Technical Design Template