Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Subscription: Fix 'Back' button not present #2741

Merged
merged 1 commit into from
Apr 15, 2024

Conversation

afterxleep
Copy link
Collaborator

Task/Issue URL: https://app.asana.com/0/414235014887631/1207054736335272/f

Description:
Fixes an issue causing the back button to not be re-enabled when cancelling a subscription purchase.

Steps to test this PR:

  • Go to duckduckgo.com/pro
  • Click on a subscription option
  • Click subscribe
  • Observe the '< Settings' back button is NOT visible while purchasing
  • Cancel the App Store purchase confirmation
  • Observe the '< Settings' back button is visible in the top left.

Internal references:

Software Engineering Expectations
Technical Design Template

@afterxleep afterxleep marked this pull request as ready for review April 15, 2024 09:21
@afterxleep
Copy link
Collaborator Author

cc @brindy

Copy link
Contributor

@miasma13 miasma13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works great 🎉

@afterxleep afterxleep merged commit b42a2f8 into main Apr 15, 2024
13 checks passed
@afterxleep afterxleep deleted the subscriptions/settings.button branch April 15, 2024 10:38
samsymons added a commit that referenced this pull request Apr 18, 2024
* main:
  Release 7.116.0-1 (#2761)
  Remove validator app (#2754)
  Fix crash when quickly adding/removing tabs in switcher (#2760)
  Fix settings navigation bar colors after reopening (#2758)
  Alpha ad-hoc lane (#2492)
  Keep a weak reference to UserScriptMessageBroker (#2755)
  Add refresh config cell to top of debug (#2735)
  VPN: Replace available interfaces in VPN metadata (#2750)
  Require device auth to be set in order to use Sync (#2722)
  Add new iOS pixels for measuring navigation  (#2730)
  Privacy pro metadata updates (#2747)
  Update autoconsent to v10.6.1 (#2734)
  Limit Stale actions to issues (#2745)
  Change DAU pixel for VPN to weekly (#2684)
  Support Autofill Domains with Port Number Suffixes (#2715)
  Update secure vault error pixels to fire daily (#2557)
  Subscription: Fix 'Back' button not present (#2741)
  Subscription State improvements + Remove SUBSCRIPTION Flag (#2726)
  Release 7.116.0-0 (#2739)
  Release 7.116.0-0 (#2737)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants