Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add pixels to measure baseline for New Tab Page sections #3024

Merged
merged 3 commits into from
Jul 3, 2024

Conversation

dus7
Copy link
Contributor

@dus7 dus7 commented Jul 2, 2024

Task/Issue URL: https://app.asana.com/0/72649045549333/1207636557063695/f
Tech Design URL:
CC:

Description:

Adds pixels allowing to have a baseline measurement of usage for existing implementation of Home Page (a.k.a. New Tab Page).

Steps to test this PR:

  1. Make sure New Tab Page Sections flag is disabled in Debug menu.
  2. Check daily pixels are firing on proper triggers defined in task, all without ATB parameter:
    1. Opening new tab page, with favorites count range in parameter
    2. Adding a favorite from browsing menu
    3. Adding a bookmark
    4. Opening favorite from NTP
    5. Opening a bookmark from list

Definition of Done (Internal Only):


Internal references:

Software Engineering Expectations
Technical Design Template

@dus7 dus7 force-pushed the mariusz/ntp-baseline-pixels branch from d50bf48 to 3b75273 Compare July 3, 2024 11:03
@dus7 dus7 marked this pull request as ready for review July 3, 2024 11:04
@dus7 dus7 requested a review from brindy July 3, 2024 11:04
Copy link
Contributor

@brindy brindy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dus7 dus7 merged commit bd398e4 into main Jul 3, 2024
14 checks passed
@dus7 dus7 deleted the mariusz/ntp-baseline-pixels branch July 3, 2024 15:57
samsymons added a commit that referenced this pull request Jul 4, 2024
* main: (24 commits)
  Add pixels to measure baseline for New Tab Page sections (#3024)
  backgrounding UI tests (#3021)
  improve bookmarks and favorites UI tests (#3019)
  [DuckPlayer] - 4. Remote Config (#3018)
  Updates BSK
  Fix issue when cancelling a download (#3030)
  Tentative fix for a crash and connectivity issues (#3027)
  autofill UI tests (#3012)
  scripts for running UI tests (#3000)
  Integrate RemoteMessaging with NewTabPage (#3017)
  Update to iOS 15 deployment target (#3001)
  Fire a pixel when removing the VPN configuration (#3014)
  Release 7.127.0-0 (#3020)
  point to BSK branch (#3016)
  [DuckPlayer] - 3. URL management & FE comms (#3007)
  Bump BSK version (#3011)
  New Tab Page layout and base elements (#3008)
  Remove Privacy Pro from device once expired account is deleted (#3009)
  Improvements to subscription settings (#2959)
  Toggle reports limiter (#3005)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants