separate atb and variant to remove duplicate variant storage #332
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brindy
changed the title
brindy
changed the title
brindy
changed the title
|
Don't review this for now, please. |
|
This is good to review now. Thanks in advance! |
brindy
changed the title
Merged
|
Just looking at this conflict. |
…_storage # Conflicts: # DuckDuckGo.xcodeproj/project.pbxproj
subsymbolic
approved these changes
Jun 20, 2018
| @@ -96,8 +96,8 @@ public struct AppUrls { | |||
|
|
|||
| public var atb: URL { | |||
| var url = URL(string: Url.atb)! | |||
| if let atb = statisticsStore.atb, let setAtb = statisticsStore.retentionAtb { | |||
| url = url.addParam(name: Param.atb, value: atb) | |||
| if let atbWithVariant = statisticsStore.atbWithVariant, let setAtb = statisticsStore.retentionAtb { | |||
|
|
||
| } | ||
|
|
||
| func testWhenVariantIsNInCurrentExperimentThenVariantIsNotRemovedFromStorage() { |
There was a problem hiding this comment.
Typo extra N in test name
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task/Issue URL:
Tech Design URL:
CC:
Description:
Steps to test this PR:
Upgrade
Install
Internal references:
Software Engineering Expectations
Technical Design Template