Release and Bitrise builds fail on any Swiftlint violation

[tomasstrba]

Description: If there is any Swiftlint warning present, release and Bitrise build will fail.

Steps to test this PR:

1. Add one unnecessary space between methods and run the app
2. Compilation should be successful with one warning
3. Archiving should fail

---

Internal references:

Software Engineering Expectations
Technical Design Template

[bwaresiak]

@tomasstrba good job 👍 One optional idea: could we check type of lint failure (maybe looking at return codes) and then echo out some more verbose error e.g. echo "error: SwiftLint validation failed"?

[tomasstrba]

@bwaresiak thanks for approval.

When I look at return codes of swiftlint, there are just three:

• 1 - Usage or system error
• 2 - Style violations of severity "Error"
• 3 - Violations of severity "warning" with --strict mode

Do you think it will tell us more information? Output already contains
"Done linting! Found X violation, Y serious in Z files."

[bwaresiak]

@tomasstrba when I look at output of a (failed) Archive operation I see:

and in the console:

Linting 'DisplayableCertificateExtensionTests.swift' (351/352)
Linting 'AtbParserTests.swift' (352/352)
Done linting! Found 1 violation, 0 serious in 352 files.
Command PhaseScriptExecution failed with a nonzero exit code

I think we could make it more clear, for instance by adding:

if ! swiftlint lint --strict; then
    echo "error: SwiftLint validation failed."
    exit 1
fi

we get following errors in Xcode:

Linting 'DisplayableCertificateExtensionTests.swift' (351/352)
Linting 'AtbParserTests.swift' (352/352)
Done linting! Found 1 violation, 0 serious in 352 files.
error: SwiftLint validation failed.

What do you think?

[tomasstrba]

@bwaresiak thank you, it's more clear now. You are right, adding specific error message helps when working in Xcode. 👍

I only added error message, no need to test again.