Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP
Browse files

Kill the LICENSE

  • Loading branch information...
commit cba79403c75d457aea2685c9f76dca0f7a0644c2 1 parent ed31968
@crazedpsyc crazedpsyc authored
Showing with 0 additions and 11 deletions.
  1. +0 −11 LICENSE
View
11 LICENSE
@@ -1,11 +0,0 @@
-Copyright 2010 Duck Duck Go, Inc.
-
-Licensed under the Apache License, Version 2.0 (the "License");
-you may not use this file except in compliance with the License.
-You may obtain a copy of the License at
-
- http://www.apache.org/licenses/LICENSE-2.0
-
-Unless required by applicable law or agreed to in writing, software
-distributed under the License is distributed on an "AS IS" BASIS,
-WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the License for the specific language governing permissions and limitations under the License.

1 comment on commit cba7940

@kentfredric
Collaborator

I'll just comment here so if somebody is reading the logs they'll understand why.

LICENSE file is generated during dzil build, and is thus already part of the release distribution.

Adding the file in addition to having it generated causes dzil to complain, because it can't tell whether to use the generated version, or the one in the source tree.

Also, this license was grossly different to the one being generated, which is the "Perl_5" license, controlled by the license = line in dist.ini, which is GPL 2 + Artistic 1 , which is very different from Apache 2.0

Though I can see how having a license file is useful in the source tree, there are better ways to do it long term, namely, you should use https://metacpan.org/pod/Dist::Zilla::Plugin::CopyFilesFromBuild to copy the LICENSE file from the built copy to the source tree during dzil build , and you should use some kind of file pruner to delete the file from the source tree prior to the dzil License plugin running to avoid a collision.

/cc @moollaza

Please sign in to comment.
Something went wrong with that request. Please try again.