You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository has been archived by the owner on Oct 15, 2022. It is now read-only.
The reason will be displayed to describe this comment to others. Learn more.
I'll just comment here so if somebody is reading the logs they'll understand why.
LICENSE file is generated during dzil build, and is thus already part of the release distribution.
Adding the file in addition to having it generated causes dzil to complain, because it can't tell whether to use the generated version, or the one in the source tree.
Also, this license was grossly different to the one being generated, which is the "Perl_5" license, controlled by the license = line in dist.ini, which is GPL 2 + Artistic 1 , which is very different from Apache 2.0
Though I can see how having a license file is useful in the source tree, there are better ways to do it long term, namely, you should use https://metacpan.org/pod/Dist::Zilla::Plugin::CopyFilesFromBuild to copy the LICENSE file from the built copy to the source tree during dzil build , and you should use some kind of file pruner to delete the file from the source tree prior to the dzil License plugin running to avoid a collision.
cba7940There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll just comment here so if somebody is reading the logs they'll understand why.
LICENSE file is generated during
dzil build, and is thus already part of the release distribution.Adding the file in addition to having it generated causes dzil to complain, because it can't tell whether to use the generated version, or the one in the source tree.
Also, this license was grossly different to the one being generated, which is the "Perl_5" license, controlled by the
license =line in dist.ini, which is GPL 2 + Artistic 1 , which is very different from Apache 2.0Though I can see how having a license file is useful in the source tree, there are better ways to do it long term, namely, you should use https://metacpan.org/pod/Dist::Zilla::Plugin::CopyFilesFromBuild to copy the LICENSE file from the built copy to the source tree during
dzil build, and you should use some kind of file pruner to delete the file from the source tree prior to the dzilLicenseplugin running to avoid a collision./cc @moollaza