Skip to content
This repository has been archived by the owner on Oct 15, 2022. It is now read-only.

* Add missing 'use strict; use warnings;' line #275

Merged
merged 1 commit into from Dec 29, 2015

Conversation

manwar
Copy link
Contributor

@manwar manwar commented Oct 6, 2015

Hi,

I propose fix to CPANTS warning regarding missing 'use strict; use warnings;' line.

Please review it.
Many Thanks.

Best Regards,
Mohammad S Anwar

@moollaza
Copy link
Member

moollaza commented Oct 6, 2015

@manwar thanks, it looks like they suggest we add it to Cmd::Query, Cmd::Release and Cmd::Test as well?

http://cpants.cpanauthors.org/dist/App-DuckPAN/errors

@moollaza
Copy link
Member

moollaza commented Oct 6, 2015

Actually, I just realized we're not using it anywhere...

@manwar
Copy link
Contributor Author

manwar commented Oct 6, 2015

In my humble opinion, where ever MooX is imported, you don't need 'use strict; use warnings;' as MooX imports Moo which brings in these checks.

@moollaza
Copy link
Member

moollaza commented Oct 6, 2015

In my humble opinion, where ever MooX is imported, you don't need 'use strict; use warnings;' as MooX imports Moo which brings in these checks.

Ah, well then I guess your fix covers everything.

Let's add no warnings 'uninitialized'; and then this should be good to merge.

@manwar
Copy link
Contributor Author

manwar commented Oct 6, 2015

Where do you suggest, we should add "no warnings 'uninitialized'"?

@zachthompson
Copy link
Contributor

@manwar The problem with allowing moox to do this behind the scenes is, if/when we remove it or use something else, we almost certainly won't remember to add strict/warnings. Doesn't hurt to have them redundantly specified afaik.

@manwar
Copy link
Contributor Author

manwar commented Oct 6, 2015

@zachthompson I agree with you.

@moollaza moollaza assigned moollaza and unassigned moollaza Dec 9, 2015
@zachthompson zachthompson self-assigned this Dec 29, 2015
@zachthompson
Copy link
Contributor

Thanks, we'll get the others later.

zachthompson added a commit that referenced this pull request Dec 29, 2015
* Add missing 'use strict; use warnings;' line
@zachthompson zachthompson merged commit 8969ae1 into duckduckgo:master Dec 29, 2015
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants