Add test to check parameters for errors and httpErrorCodes (#125)

* Add test for error fields * Add test exceptions * Fix test value * Update error desc * More updates to test * Skip description encoding test on macOS * More exceptions * More exceptions * Update error test cases * Parameter name * Update expected test value * Update broken-site-reporting/README.md * Update broken-site-reporting/README.md --------- Co-authored-by: Ben Moon <software@guiltydolphin.com>
duckduckgo · Feb 23, 2024 · a603ff9 · a603ff9
1 parent 438faf5
commit a603ff9
Show file tree

Hide file tree

Showing 2 changed files with 41 additions and 3 deletions.
diff --git a/broken-site-reporting/README.md b/broken-site-reporting/README.md
@@ -25,6 +25,8 @@ Test suite specific fields:
 - `model` - string - name of the device model (native apps only)
 - `os` - string - operating system name (native apps only)
 - `gpcEnabled` - boolean - if GPC is enabled or not (native apps only) - GPC can be disabled by user or by remote config
+- `errorDescriptions` - array of strings - optional field containing descriptions from errors generated by failed page loads
+- `httpErrorCodes` - array of int - optional field containing the HTTP status codes returned by the page load
 - `expectReportURLPrefix` - string - resulting report URL should be prefixed with this string
 - `expectReportURLParams` - Array of `{name: '', value: ''}` objects - resulting report URL should have the following set of URL parameters with matching values
     - `value` is an optional check for an exact value match.

diff --git a/broken-site-reporting/tests.json b/broken-site-reporting/tests.json
@@ -106,7 +106,8 @@
                     {"name": "protectionsState", "value": "true"}
                 ],
                 "exceptPlatforms": [
-                    "ios-browser"
+                    "ios-browser",
+                    "macos-browser"
                 ]
             },
             {
@@ -134,7 +135,8 @@
                     {"name": "protectionsState", "value": "true"}
                 ],
                 "exceptPlatforms": [
-                    "ios-browser"
+                    "ios-browser",
+                    "macos-browser"
                 ]
             },
             {
@@ -162,7 +164,8 @@
                     {"name": "protectionsState", "value": "true"}
                 ],
                 "exceptPlatforms": [
-                    "ios-browser"
+                    "ios-browser",
+                    "macos-browser"
                 ]
             },
             {
@@ -211,6 +214,7 @@
                 ],
                 "exceptPlatforms": [
                     "ios-browser",
+                    "macos-browser",
                     "safari-extension"
                 ]
             },
@@ -421,6 +425,38 @@
                     "safari-extension",
                     "windows-browser"
                 ]
+            },
+            {
+                "name": "Test error information and HTTP status code are included",
+                "siteURL": "https://example.test/",
+                "wasUpgraded": true,
+                "category": "content",
+                "blockedTrackers": ["bad.tracker.test", "tracking.test"],
+                "surrogates": ["surrogate.domain.test", "domain2.test"],
+                "atb": "v123-456g",
+                "blocklistVersion": "abc123",
+                "remoteConfigEtag": "abd142",
+                "remoteConfigVersion": "1234",
+                "protectionsEnabled": true,
+                "expectReportURLPrefix": "https://improving.duckduckgo.com/t/epbf",
+                "errorDescriptions": ["net::ERR_NAME_NOT_RESOLVED","net::ERR_ABORTED"],
+                "httpErrorCodes": [304, 200],
+                "expectReportURLParams": [
+                    {"name": "category", "value": "content"},
+                    {"name": "siteUrl", "value": "https%3A%2F%2Fexample.test%2F"},
+                    {"name": "upgradedHttps", "value": "true"},
+                    {"name": "tds", "value": "abc123"},
+                    {"name": "blockedTrackers", "value": "bad.tracker.test,tracking.test"},
+                    {"name": "surrogates", "value": "surrogate.domain.test,domain2.test"},
+                    {"name": "protectionsState", "value": "true"},
+                    {"name": "errorDescriptions", "value": "%5B%22net%3A%3AERR_NAME_NOT_RESOLVED%22%2C%22net%3A%3AERR_ABORTED%22%5D"},
+                    {"name": "httpErrorCodes", "value": "304,200"}
+                ],
+                "exceptPlatforms": [
+                    "android-browser",
+                    "safari-extension",
+                    "windows-browser"
+                ]
             }
         ]
     }