Fortune: Switching to text template (#3063)

* Fortune: Switching to text template * Fortune: Adding subtitle and using Test::Deep
duckduckgo · May 15, 2016 · 58ce9b0 · 58ce9b0
1 parent 3349534
commit 58ce9b0
Show file tree

Hide file tree

Showing 2 changed files with 27 additions and 18 deletions.
diff --git a/lib/DDG/Goodie/Fortune.pm b/lib/DDG/Goodie/Fortune.pm
@@ -18,12 +18,15 @@ handle remainder => sub {
     my $output = $fortune_file->get_random_fortune();
     $output =~ s/\n/ /g;
 
-    return $output,
-      structured_answer => {
-        input     => [],
-        operation => 'Random fortune',
-        result    => $output
-      };
+    return $output, structured_answer => {
+        data => {
+            title => $output,
+            subtitle => "Random Fortune"
+        },
+        templates => {
+            group => 'text'
+        }
+    };
 };
 
 1;
diff --git a/t/Fortune.t b/t/Fortune.t
@@ -3,26 +3,32 @@
 use strict;
 use warnings;
 use Test::More;
+use Test::Deep;
 use DDG::Test::Goodie;
 
 zci answer_type => 'fortune';
 zci is_cached   => 0;
 
-my @fortune = (
-    '-ANY-',
-    structured_answer => {
-        input     => [],
-        operation => 'Random fortune',
-        result    => '-ANY-'
-    });
+sub build_test
+{
+    return test_zci(re(qr/.+/), structured_answer => {
+        data => {
+            title => re(qr/.+/),
+            subtitle => 'Random Fortune'
+        },
+        templates => {
+            group => 'text'
+        }
+    })
+}
 
 ddg_goodie_test(
     [qw( DDG::Goodie::Fortune )],
-    'gimmie a fortune cookie'           => test_zci(@fortune),
-    'gimmie a unix fortune'             => test_zci(@fortune),
-    'give me a fortune cookie'         => test_zci(@fortune),
-    'give me a unix fortune'           => test_zci(@fortune),
-    'unix fortune cookie'               => test_zci(@fortune),
+    'gimmie a fortune cookie'           => build_test(),
+    'gimmie a unix fortune'             => build_test(),
+    'give me a fortune cookie'          => build_test(),
+    'give me a unix fortune'            => build_test(),
+    'unix fortune cookie'               => build_test(),
     'how do I make a fortune overnight' => undef,
     "bill gates' fortune"               => undef,
 );