Skip to content
This repository has been archived by the owner on Oct 15, 2022. It is now read-only.

Deal with handling XSS issues in the query #223

Closed
yegg opened this issue Oct 7, 2013 · 3 comments
Closed

Deal with handling XSS issues in the query #223

yegg opened this issue Oct 7, 2013 · 3 comments

Comments

@yegg
Copy link
Member

yegg commented Oct 7, 2013

The query can have XSS bugs in it and so should not be displayed directly. I'm not sure if we currently offer them an escaped version like we have in the backend q_escape. If not we should and it can mimic the backend function.

Also, we need to add to the docs about not returning the query directly in html. For non-HTML we already escape it.

@moollaza
Copy link
Member

An explanation about not returning the raw query in the IA's HTML has been added to the docs in this: duckduckgo/duckduckgo-documentation#39

@moollaza
Copy link
Member

Moving this issue to the https://github.com/duckduckgo/duckduckgo repo as the fix would need to be implemented there.

@jagtalon
Copy link
Member

@moollaza Cool!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants