Skip to content
This repository has been archived by the owner on Oct 15, 2022. It is now read-only.

WorkdaysBetween: Support "business days between jan 10 and jan 20" format #346

Closed
jagtalon opened this issue Feb 27, 2014 · 4 comments · Fixed by #614
Closed

WorkdaysBetween: Support "business days between jan 10 and jan 20" format #346

jagtalon opened this issue Feb 27, 2014 · 4 comments · Fixed by #614
Assignees
@mintsoft
Labels
Improvement Low-Hanging Fruit Priority: Low

Comments

@jagtalon
Copy link
Member

Imply that it's this year.
@loganom
Copy link
Collaborator

loganom commented Jul 1, 2014

I'm going to work on this.

@loganom loganom self-assigned this Jul 1, 2014
@loganom
Copy link
Collaborator

loganom commented Aug 15, 2014

I am apparently too busy for this at the moment. :(

@loganom loganom removed their assignment Aug 15, 2014
@mintsoft
Copy link
Collaborator

Don't worry about this @loganom there's a massive rewrite of all date handling stuff in-progress by myself and @mwmiller : #576

Feel free to review/comment though, all input welcomed

cc @jagtalon

@mintsoft mintsoft self-assigned this Aug 21, 2014
@mintsoft
Copy link
Collaborator

Not sure if this is now already handled by parse_vague_string; needs investigation and tests adding if is

mintsoft added a commit that referenced this issue Aug 30, 2014
@mintsoft
WorkdaysBetween: Using new DatesRole functionality to fix #346
080df14
@mintsoft mintsoft mentioned this issue Aug 30, 2014
Merged
moollaza added a commit that referenced this issue Sep 4, 2014
@moollaza
Merge pull request #614 from duckduckgo/mintsoft/workdays_between
859f7e7 
Extending Dates Role's Vague String handling & Fixing #346
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@mintsoft mintsoft

Labels
Improvement Low-Hanging Fruit Priority: Low
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Extending Dates Role's Vague String handling & Fixing #346 duckduckgo/zeroclickinfo-goodies
3 participants
@jagtalon @mintsoft @loganom