Add IsItChristmas IA #1079

stevenmg · 2015-03-27T01:21:48Z

IsItChristmas

What does your Instant Answer do?
It adds a simple and fun answer to the question of whether or not it is currently Christmas.

What problem does your Instant Answer solve (Why is it better than organic links)?
It allows people to find an answer to the important question of whether or not it is Christmas without the need to click through to isitchristmas.com.

What is the data source for your Instant Answer? (Provide a link if possible)
The current Date combined with my knowledge of the fact that Christmas is always December 25th

Why did you choose this data source?
This question seems invalid in the current context.

Are there any other alternative (better) data sources?
Nope.

What are some example queries that trigger this Instant Answer?
"is it christmas"

Which communities will this Instant Answer be especially useful for? (gamers, book lovers, etc)
Anyone who loves Christmas

Is this Instant Answer connected to a DuckDuckHack Instant Answer idea?
Nope

Which existing Instant Answers will this one supercede/overlap with?
None

Are you having any problems? Do you need our help with anything?
Using Codio it is impossible to change the date in order to ensure that the IA really will say "Yes" on December 25th so if someone could test that more thoroughly that would be great.

What does the Instant Answer look like? (Provide a screenshot for new or updated Instant Answers)

Checklist

Please place an 'X' where appropriate.

- [x] Added metadata and attribution information (https://duck.co/duckduckhack/metadata)
- [x] Wrote test file and added to t/ directory (https://duck.co/duckduckhack/goodie_tests)
- [x] Verified that instant answer adheres to design guidelines (https://duck.co/duckduckhack/design_styleguide)
- [] Verified that instant answer adheres to code styleguide (https://duck.co/duckduckhack/code_styleguide)
- [] Tested cross-browser compatibility

    Please let us know which browsers/devices you've tested on:
    - Windows 8
        - [] Google Chrome
        - [x] Firefox
        - [] Opera
        - [] IE 10

    - Windows 7
        - [] Google Chrome
        - [] Firefox
        - [] Opera
        - [] IE 8
        - [] IE 9
        - [] IE 10

    - Windows XP
        - [] IE 7
        - [] IE 8

    - Mac OSX
        - [] Google Chrome
        - [] Firefox
        - [] Opera
        - [] Safari

    - iOS (iPhone)
        - [] Safari Mobile
        - [] Google Chrome
        - [] Opera

    - iOS (iPad)
        - [] Safari Mobile
        - [] Google Chrome
        - [] Opera

    - Android
        - [] Firefox
        - [] Native Browser
        - [] Google Chrome
        - [] Opera

moollaza · 2015-03-27T02:08:16Z

@stevenmg thanks for contributing! We really appreciate it 😃

We'll be sure to give you some feedback shortly!

puskin94 · 2015-03-28T11:15:12Z

lib/DDG/Goodie/IsItChristmas.pm

+    print($m);
+    print($d);
+
+    if ($m == 12 && $d == 25) {


I think that ($m == 12 && $d == 25) ? return "Yes" : return "No"; is styled better ;)

I would disagree! I'd much prefer

return "Yes" if ($m == 12 && $d == 25); return "No";

or

return "No" unless ($m == 12 && $d == 25); return "Yes";

puskin94 · 2015-03-29T08:44:29Z

@mintsoft only as a comparison... Why do you prefer your if solution instead of mine?

mintsoft · 2015-03-29T13:12:50Z

@puskin94 A few relatively minor reasons; it's more certainly more perlistic. The main advantage is that I think it's clearer to see the default vs the exception case whereas with a ternary it's nowhere near as obvious imo

puskin94 · 2015-03-29T13:18:27Z

@mintsoft Yep, it is more and more explicit. But, in my opinion and in the style guide in my own mind, I think that compact is better ;)

mintsoft · 2015-03-29T15:29:55Z

@puskin94 I think it's probably a matter of style mainly. In my experience I've found that clarity is the most important thing, especially when working in a team; however I'm sure there are other philosophies.

stevenmg · 2015-03-31T16:46:28Z

Thanks for the input guys. I typically prefer more clear over more compact. Does the style guide specify which one should be used?

Also, I like the idea of using mock time for tests, I will work on that later.

mintsoft · 2015-03-31T18:10:28Z

@stevenmg it's totally up to you; whichever you prefer!

mintsoft · 2015-03-31T18:35:43Z

@stevenmg also btw I don't see any real problem with what you have currently there; there's certainly no need to change it unless you want to

mintsoft · 2015-04-03T20:22:27Z

@stevenmg I've added the Work in Progress label for now, whenever you're finished up just remove it 👍

stevenmg · 2015-04-05T20:10:39Z

My mental style guide says to keep it as is (probably because I use Java a lot) so I think that is what I'll do unless there is another reason to change it.

stevenmg · 2015-04-05T20:58:18Z

I have added mock time for tests as well as 'is it xmas' as a trigger phrase. If anything else should be added let me know.

stevenmg · 2015-04-05T21:01:08Z

I was just looking at the Travis CI status for my earlier commits and it looks like the tests are failing for this IA. I am going to wait for the results of the latest commits and then see what I can do.

...or I'll just run a test from Codio :)

stevenmg · 2015-04-05T21:20:32Z

I just fixed up the test file. I think I'm done here.

mintsoft · 2015-04-06T00:42:29Z

lib/DDG/Goodie/IsItChristmas.pm

+# ABSTRACT: Answers the question of whether or not it is Christmas with a simple yes or no answer
+
+use DDG::Goodie;
+use Date::Calc;


Can you switch this to: use DateTime; as we already use this module in the Dates role

javathunderman · 2015-04-24T19:20:17Z

@mintsoft @stevenmg Is this ready to be merged?

mintsoft · 2015-04-24T19:28:17Z

@javathunderman almost, @abeyang does this look aright to you or would you prefer it to use the structured answer?

javathunderman · 2015-05-20T00:07:46Z

ping @mintsoft @abeyang

moollaza · 2015-05-21T15:48:31Z

Hey guys, we're discussing this IA internally with regards to whether or not it deserves to be an IA given the narowness of the queryspace. We may decide it needs to be generalized, or perhaps this should be handled by the coming Holidays IA.

I'll be sure to keep you updated!

javathunderman · 2015-05-21T17:59:35Z

Holidays IA? :)

moollaza · 2015-05-25T23:56:18Z

duckduckgo/zeroclickinfo-spice#1701

moollaza · 2015-07-15T20:19:23Z

Hey guys, sorry for the long delay. I feel like the queries this IA handles should really be handled by the coming Holidays IA as it has a much broader scope.

We feel that this IA is a little too narrow in scope.

@stevenmg I'm really sorry we can't move forward with this but we really hope you're still interested in contributing! Is there anything else you'd like to work on? A cheat sheet perhaps?

Add IsItChristmas IA

3b0b08f

moollaza added New Instant Answer Status: Needs Community Review labels Mar 27, 2015

puskin94 reviewed Mar 28, 2015
View reviewed changes

steveglick added 2 commits March 31, 2015 16:23

Removed unnecessary comments and debug code

33bf98b

Added abstract

13be010

mintsoft added the Status: Work In Progress label Apr 3, 2015

steveglick added 2 commits April 5, 2015 20:51

Add mock time in tests

c7d64ba

Add 'is it xmas' as a trigger

39a6530

Fixed test file

4940a42

mintsoft removed the Status: Work In Progress label Apr 6, 2015

mintsoft reviewed Apr 6, 2015
View reviewed changes

Changed Date::Calce to DateTime

d45b566

moollaza added the Status: On Hold label May 21, 2015

moollaza closed this Jul 15, 2015

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add IsItChristmas IA #1079

Add IsItChristmas IA #1079

stevenmg commented Mar 27, 2015

moollaza commented Mar 27, 2015

puskin94 Mar 28, 2015

mintsoft Mar 28, 2015

puskin94 commented Mar 29, 2015

mintsoft commented Mar 29, 2015

puskin94 commented Mar 29, 2015

mintsoft commented Mar 29, 2015

stevenmg commented Mar 31, 2015

mintsoft commented Mar 31, 2015

mintsoft commented Mar 31, 2015

mintsoft commented Apr 3, 2015

stevenmg commented Apr 5, 2015

stevenmg commented Apr 5, 2015

stevenmg commented Apr 5, 2015

stevenmg commented Apr 5, 2015

mintsoft Apr 6, 2015

javathunderman commented Apr 24, 2015

mintsoft commented Apr 24, 2015

javathunderman commented May 20, 2015

moollaza commented May 21, 2015

javathunderman commented May 21, 2015

moollaza commented May 25, 2015

moollaza commented Jul 15, 2015

Add IsItChristmas IA #1079

Add IsItChristmas IA #1079

Conversation

stevenmg commented Mar 27, 2015

IsItChristmas

Checklist

moollaza commented Mar 27, 2015

puskin94 Mar 28, 2015

Choose a reason for hiding this comment

mintsoft Mar 28, 2015

Choose a reason for hiding this comment

puskin94 commented Mar 29, 2015

mintsoft commented Mar 29, 2015

puskin94 commented Mar 29, 2015

mintsoft commented Mar 29, 2015

stevenmg commented Mar 31, 2015

mintsoft commented Mar 31, 2015

mintsoft commented Mar 31, 2015

mintsoft commented Apr 3, 2015

stevenmg commented Apr 5, 2015

stevenmg commented Apr 5, 2015

stevenmg commented Apr 5, 2015

stevenmg commented Apr 5, 2015

mintsoft Apr 6, 2015

Choose a reason for hiding this comment

javathunderman commented Apr 24, 2015

mintsoft commented Apr 24, 2015

javathunderman commented May 20, 2015

moollaza commented May 21, 2015

javathunderman commented May 21, 2015

moollaza commented May 25, 2015

moollaza commented Jul 15, 2015