This repository has been archived by the owner on Oct 15, 2022. It is now read-only.
Password: Fixes #1565 #1597
Merged
Password: Fixes #1565 #1597
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -19,7 +19,7 @@ topics 'cryptography'; | |||
| zci answer_type => 'pw'; | |||
| zci is_cached => 0; | |||
|
|
|||
| triggers start => 'password', 'random password', 'pw', 'random pw', 'pwgen'; | |||
| triggers startend => 'password', 'random password', 'generate password', 'generate random password', 'password generator', 'pw', 'random pw', 'pwgen'; | |||
There was a problem hiding this comment.
@cinlloc we can keep this to start unless we expect these words to appear at the end of a mult-word query (which might not be ideal)
|
@cinlloc thanks for updating, apologies for the delay. I've set this up for deployment to Beta and will review it shortly. We appreciate your patience! |
|
@cinlloc this LGTM 👍 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A simple fix, maybe not sufficiently filtering triggers. Let me know what you think about it...
IA Page: https://duck.co/ia/view/password