Conversation
@@ -0,0 +1,65 @@ | |||
{ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ankushg07 uh oh, this shouldn't be here. You'll want to use Git Branches if you're going to be submitting multiple PRs
@moollaza i used a new branch "vitamin " for this CS .. Dont why it is merging with old one |
@ankushg07 at branch
|
@moollaza done with the branch issues |
"sections":{ | ||
"Source":[{ | ||
"key":"Vitamin A", | ||
"val":"Liver/fish/Milk/cheese " |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's replace the /
with ,
and normalize the capital letters. Either everything should have a capital letter, or only the first word.
@ankushg07 I've left some feedback. An IA Page will be created for this and then the Cheat Sheet will be deployed to Beta.duckduckgo.com for testing. Please address my comments and leave a comment here once everything is fixed again. Thanks! |
@moollaza done with all issues pointed out .. |
"sections": { | ||
"Source": [{ | ||
"key": "Vitamin A", | ||
"val": "Liver,fish,milk,cheese " |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
these commas need a space after them, otherwise this is difficult to read
@ankushg07 just a couple minor fixes required and then this should be good. |
Automated screenshot from https://beta.duckduckgo.com |
@moollaza issues fixed .!! |
Automated screenshot from https://beta.duckduckgo.com/?q=Vitamin+Cheat+Sheet&ia=cheatsheet |
"val": "Prevent cell damage" | ||
},{ | ||
"key": "Vitamin D", | ||
"val": "Make Bone & Teeth stronger and healthier" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should be something like "Maintain the health of bones and teeth"
@moollaza any issues sir?? |
@ankushg07 looks like @MrChrisW pointed out a grammar fix, I'll take a look for any more.. |
"val": "Helps with energy production in your body" | ||
},{ | ||
"key": "Vitamin B3", | ||
"val": "Use protein, fat and carbohydrate to make energy" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We've switched tenses here. The previous lines are in past tense: Helps, Prevents
. This should be `Helps your body use protiens, fats, and carbohydrates to make energy" -- or similar
@ankushg07 these may be a better source of data:
They provides nice descriptions of what the vitamin does, and where it comes from. Similarly, something like http://goop.com/a-vitamin-supplement-cheat-sheet-2/ could be converted into a cheat sheet using the new |
@ankushg07 the more I look at this, and the table on Wiki -- I'm starting to think we should flip this around. The vitamins should be the sections, and then the keys should be the column names, and the values should be the text in the table. Does that make more sense? Organizing it this way allows us to show more info about each vitamin and you only need to go to 1 section to find out all about the vitamin |
If you'd like, I can merge this and create an issue for someone else to do this -- I know it means re-doing all the work... @duckduckgo/community-leaders what are your thoughts -- do you prefer the 2 section approach, or would you find it more useful organized by vitamin? My opinion isn't the only one that matters ;) |
@moollaza 2 sections LGTM 👍 |
I personally would like to see it organized by vitamin. |
@moollaza @preemeijer @javathunderman any final verdict sir? I can manage those changes if needed |
@ankushg07 it looks like there are merge conflicts now. I'll merge in what you have and create an issue for it to be improved. Sorry this one has taken so long to merge! |
@ankushg07 congrats! It's live: https://duckduckgo.com/?q=Vitamin%20Cheat%20Sheet&ia=answer Thanks again for taking the time to contribute! We really appreciate it. Feel free to stick around and comment/help on other PR's, tackle open issues or even submit more Instant Answers! |
What does your Instant Answer do?
It displays the sources and benefits of each vitamin
What is the data source for your Instant Answer? (Provide a link if possible)
wikipedia
Which communities will this Instant Answer be especially useful for? (gamers, book lovers, etc)
students, general public
Are you having any problems? Do you need our help with anything?
no
What does the Instant Answer look like? (Provide a screenshot for new or updated Instant Answers)
IA Page: https://duck.co/ia/view/vitamin_cheat_sheet