Skip to content
This repository has been archived by the owner on Oct 15, 2022. It is now read-only.

Vitamin #1722

Closed
wants to merge 7 commits into from
Closed

Vitamin #1722

wants to merge 7 commits into from

Conversation

ankushg07
Copy link
Contributor

What does your Instant Answer do?
It displays the sources and benefits of each vitamin

What is the data source for your Instant Answer? (Provide a link if possible)
wikipedia

Which communities will this Instant Answer be especially useful for? (gamers, book lovers, etc)
students, general public

Are you having any problems? Do you need our help with anything?
no

What does the Instant Answer look like? (Provide a screenshot for new or updated Instant Answers)
vitamins


IA Page: https://duck.co/ia/view/vitamin_cheat_sheet

@@ -0,0 +1,65 @@
{
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ankushg07 uh oh, this shouldn't be here. You'll want to use Git Branches if you're going to be submitting multiple PRs

@ankushg07
Copy link
Contributor Author

@moollaza i used a new branch "vitamin " for this CS .. Dont why it is merging with old one
Could you please guide me?

@codenirvana
Copy link
Collaborator

@ankushg07 at branch vitamin :

git rm share/goodie/cheat_sheets/safari.json
git commit -m "removed safari.json"

@ankushg07
Copy link
Contributor Author

@moollaza done with the branch issues

"sections":{
"Source":[{
"key":"Vitamin A",
"val":"Liver/fish/Milk/cheese "
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's replace the / with , and normalize the capital letters. Either everything should have a capital letter, or only the first word.

@moollaza moollaza self-assigned this Nov 16, 2015
@moollaza
Copy link
Member

@ankushg07 I've left some feedback. An IA Page will be created for this and then the Cheat Sheet will be deployed to Beta.duckduckgo.com for testing.

Please address my comments and leave a comment here once everything is fixed again. Thanks!

@daxtheduck daxtheduck deployed to beta.duckduckgo.com November 18, 2015 17:35 Active
@ankushg07
Copy link
Contributor Author

@moollaza done with all issues pointed out ..
hope its good to go now :)

@daxtheduck
Copy link

"sections": {
"Source": [{
"key": "Vitamin A",
"val": "Liver,fish,milk,cheese "
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

these commas need a space after them, otherwise this is difficult to read

@moollaza
Copy link
Member

@ankushg07 just a couple minor fixes required and then this should be good.

@daxtheduck
Copy link

@daxtheduck daxtheduck deployed to beta.duckduckgo.com November 22, 2015 18:53 Active
@ankushg07
Copy link
Contributor Author

@moollaza issues fixed .!!

"val": "Prevent cell damage"
},{
"key": "Vitamin D",
"val": "Make Bone & Teeth stronger and healthier"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be something like "Maintain the health of bones and teeth"

@ankushg07
Copy link
Contributor Author

@moollaza any issues sir??

@moollaza
Copy link
Member

@ankushg07 looks like @MrChrisW pointed out a grammar fix, I'll take a look for any more..

"val": "Helps with energy production in your body"
},{
"key": "Vitamin B3",
"val": "Use protein, fat and carbohydrate to make energy"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We've switched tenses here. The previous lines are in past tense: Helps, Prevents. This should be `Helps your body use protiens, fats, and carbohydrates to make energy" -- or similar

@moollaza
Copy link
Member

@ankushg07 these may be a better source of data:

They provides nice descriptions of what the vitamin does, and where it comes from.

Similarly, something like http://goop.com/a-vitamin-supplement-cheat-sheet-2/ could be converted into a cheat sheet using the new links template. The headers could be he sections and each item could be a named link.

@ankushg07
Copy link
Contributor Author

@moollaza @MrChrisW fixed the grammatical mistakes !!

@moollaza
Copy link
Member

@ankushg07 the more I look at this, and the table on Wiki -- I'm starting to think we should flip this around.

The vitamins should be the sections, and then the keys should be the column names, and the values should be the text in the table.

Does that make more sense?

Organizing it this way allows us to show more info about each vitamin and you only need to go to 1 section to find out all about the vitamin

@moollaza
Copy link
Member

If you'd like, I can merge this and create an issue for someone else to do this -- I know it means re-doing all the work...

@duckduckgo/community-leaders what are your thoughts -- do you prefer the 2 section approach, or would you find it more useful organized by vitamin?

My opinion isn't the only one that matters ;)

@javathunderman
Copy link
Collaborator

@moollaza 2 sections LGTM 👍

@preemeijer
Copy link
Collaborator

I personally would like to see it organized by vitamin.

@ankushg07
Copy link
Contributor Author

@moollaza @preemeijer @javathunderman any final verdict sir?

I can manage those changes if needed

@moollaza
Copy link
Member

@ankushg07 it looks like there are merge conflicts now. I'll merge in what you have and create an issue for it to be improved.

Sorry this one has taken so long to merge!

@moollaza moollaza mentioned this pull request Dec 24, 2015
moollaza added a commit that referenced this pull request Dec 24, 2015
@moollaza moollaza closed this Dec 24, 2015
@moollaza
Copy link
Member

@ankushg07 congrats! It's live: https://duckduckgo.com/?q=Vitamin%20Cheat%20Sheet&ia=answer

Thanks again for taking the time to contribute! We really appreciate it. Feel free to stick around and comment/help on other PR's, tackle open issues or even submit more Instant Answers!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants