C Math Functions CheatSheet added #3257

manrajgrover · 2016-06-16T10:46:10Z

What does your Pull Request do (check all that apply)?

Choose the most relevant items and use the following title template to name
your Pull Request.

New Instant Answer
- Cheat Sheets: New {C Math Functions} Cheat Sheet
- Other: New {IA Name} Instant Answer
Improvement
- Bug fix: {IA Name}: Fix {Issue number or one-line description}
- Enhancement: {IA Name}: {Description of Improvements}
Non–Instant Answer
- Other (Role, Template, Test, Documentation, etc.): {GoodieRole/Templates/Tests/Docs}: {Short Description}

Description of changes

This pull request adds C Math Functions Cheatsheet to allow easy access to functions available in math.h library

Which issues (if any) does this fix?

None

People to notify (@mention interested parties)

@zekiel @moollaza

Instant Answer Page: https://duck.co/ia/view/c_math_functions_cheat_sheet

Maintainer: @manrajgrover

122131 · 2016-06-16T11:13:34Z

share/goodie/cheat_sheets/json/c-math-functions.json

@@ -0,0 +1,165 @@
+{
+    "id": "c_math_functions_cheat_sheet",


I think you should replace "c_math_functions_cheat_sheet" with "c_math_functions"

I referred to other cheat sheets for renaming this. I guess this is why it failed in first instance. Now, its failing due to alias and not able to find the cheat sheet page.

@122131 the current ID is correct 👍

All cheat sheets should have an ID ending in _cheat_sheet -- the IA Page ID should match that as well

manrajgrover · 2016-06-16T11:16:52Z

@Zekeil Please check. I have no idea why Travis Build is not able to locate Cheat Sheet page.

sahildua2305 · 2016-06-16T11:39:18Z

@manrajgrover Build result says -

FAIL: aliases contain the cheat sheet name (c math functions)

Remove c math functions from aliases and it will work 😄

manrajgrover · 2016-06-16T11:52:58Z

@sahildua2305 Yes, I have figured that out. I plan to commit it together with other fixes(if any left). Thank you. 😊

gaulrobe · 2016-06-16T15:06:48Z

share/goodie/cheat_sheets/json/c-math-functions.json

+
+    "aliases": [
+        "c mathematics functions",
+        "math",


Is math too generic here?

Agreed, should I remove it?

I would say yes.

gaulrobe · 2016-06-16T15:23:03Z

share/goodie/cheat_sheets/json/c-math-functions.json

+        "math.h"
+    ],
+
+    "template_type": "reference",


Should the type for this be code?

@gaulrobe I have followed this as per this similar cheat sheet previously created. 😊

Fair enough, but it just might look better as a code template. Give it a try and see which one you think looks better! :)

daxtheduck · 2016-06-16T15:32:38Z

Automated screenshot from [beta.duckduckgo.com](https://beta.duckduckgo.com/?q=C Math Functions Cheat Sheet)

Mobile screenshot

zekiel · 2016-06-17T13:01:08Z

share/goodie/cheat_sheets/json/c-math-functions.json

+                "val": "Returns the value of 10 raised to the xth power."
+            },
+            {
+                "key": "double log(double x)",


missing a space between 'log' and '(double x)' ?

zekiel · 2016-06-17T13:01:47Z

@manrajgrover this seems ok to merge if you can fix or acknowledge that spacing issue: https://github.com/duckduckgo/zeroclickinfo-goodies/pull/3257/files#r67506047

manrajgrover · 2016-06-17T15:39:47Z

@zekiel Make a quick fix. Please review. 😊

jophab · 2016-06-17T16:28:22Z

share/goodie/cheat_sheets/json/c-math-functions.json

+            {
+                "key": "complex double catanh (complex double z)",
+                "val": "Return the inverse complex hyperbolic tangent of z."
+            }


Lets remove the periods at end of val fields

@jophab For every val field? It may look odd for val fields containing two sentences. Let me know.

Yes, that is what we usually follow

@jophab Will make the changes along with few changes being discussed. Thank you for sharing this. 😊

nalinbhardwaj · 2016-06-18T04:22:33Z

One small suggestion, you can include more functions like ceil, floor, fabs and others that are commonly used. Also, I guess it should trigger on "C++ Math cheat sheet" as well, as the library is shared.

manrajgrover · 2016-06-18T10:19:12Z

@nalinbhardwaj Nice catch! I just noticed I missed them because they were mentioned in the next section of source page. Will add them. Also, I have noticed that complex number functions mentioned require <complex.h> to be included. Will fix that.

C++ Math library has more functions (included in C++11) which are not part of math.h. I feel we should have a separate IA for it. Please share your view. 😊

nalinbhardwaj · 2016-06-18T15:25:01Z

@manrajgrover Sounds like a good idea but personally most C++ programmers I know use these functions interchangeably(in the sense, they are as frequently used in C++ development as C development). Maybe the C cheat sheet can be edited to include C++ math library, with only a small mark/note mentioning that it is C++11+ specific and not available for C..

manrajgrover · 2016-06-18T22:31:14Z

cc @zekiel

Should I add C++ functions in this IA?

zekiel · 2016-06-20T15:58:01Z

It's probably ok as-is. If someone wants to change it in the future, it won't be difficult.

Let me know if you'd like a merge @manrajgrover

manrajgrover · 2016-06-20T16:00:14Z

Sure @zekiel, lets merge this. 😄

Also, please see #3263. It is stopping me from making more PRs. 😊

zekiel · 2016-06-21T14:33:28Z

Thanks @manrajgrover, please see my note at #3263. Would you like to update this later or merge as is?

manrajgrover · 2016-06-21T14:52:49Z

@zekiel Perfect. I would like to make a few changes before merging. Will push them today. 😄

manrajgrover · 2016-06-23T22:50:50Z

@zekiel This looks fixed now. Please check. 😄

daxtheduck · 2016-06-23T22:58:28Z

Automated screenshot from [beta.duckduckgo.com](https://beta.duckduckgo.com/?q=C Math Functions Cheat Sheet)

Mobile screenshot

manrajgrover added 2 commits June 16, 2016 10:36

C Math Functions CheatSheet added

53db133

Fixes name for Travis Build

bdd9455

daxtheduck had a problem deploying to beta.duckduckgo.com June 16, 2016 11:01 Error

Another fix for Travis Build

f91f961

daxtheduck deployed to beta.duckduckgo.com June 16, 2016 11:09 Active

122131 reviewed Jun 16, 2016
View reviewed changes

Removed conflicting alias

b504b0d

daxtheduck deployed to beta.duckduckgo.com June 16, 2016 14:57 Active

gaulrobe reviewed Jun 16, 2016
View reviewed changes

Removed generic alias

580c355

gaulrobe reviewed Jun 16, 2016
View reviewed changes

moollaza added New Instant Answer CheatSheet labels Jun 16, 2016

zekiel reviewed Jun 17, 2016
View reviewed changes

Fixes spacing issue

7017612

daxtheduck deployed to beta.duckduckgo.com June 17, 2016 15:34 Active

jophab reviewed Jun 17, 2016
View reviewed changes

zekiel mentioned this pull request Jun 21, 2016

C++ Algorithms Cheat Sheet should be verbose like C++ Strings #3263

Closed

Adds more functions | Removes few complex header functions

f6b7070

daxtheduck deployed to beta.duckduckgo.com June 23, 2016 22:45 Active

zekiel merged commit 469463e into duckduckgo:master Jun 24, 2016

pjhampton mentioned this pull request Apr 25, 2017

npm: Improve the single detail view #4132

Closed

4 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

C Math Functions CheatSheet added #3257

C Math Functions CheatSheet added #3257

manrajgrover commented Jun 16, 2016 •

edited

122131 Jun 16, 2016

manrajgrover Jun 16, 2016 •

edited

moollaza Jun 16, 2016

manrajgrover commented Jun 16, 2016

sahildua2305 commented Jun 16, 2016

manrajgrover commented Jun 16, 2016

gaulrobe Jun 16, 2016

manrajgrover Jun 16, 2016

gaulrobe Jun 16, 2016

gaulrobe Jun 16, 2016

manrajgrover Jun 16, 2016

gaulrobe Jun 16, 2016

daxtheduck commented Jun 16, 2016

zekiel Jun 17, 2016

zekiel commented Jun 17, 2016

manrajgrover commented Jun 17, 2016

jophab Jun 17, 2016 •

edited

manrajgrover Jun 17, 2016

jophab Jun 18, 2016

manrajgrover Jun 18, 2016

nalinbhardwaj commented Jun 18, 2016

manrajgrover commented Jun 18, 2016

nalinbhardwaj commented Jun 18, 2016

manrajgrover commented Jun 18, 2016

zekiel commented Jun 20, 2016

manrajgrover commented Jun 20, 2016

zekiel commented Jun 21, 2016

manrajgrover commented Jun 21, 2016

manrajgrover commented Jun 23, 2016

daxtheduck commented Jun 23, 2016

C Math Functions CheatSheet added #3257

C Math Functions CheatSheet added #3257

Conversation

manrajgrover commented Jun 16, 2016 • edited

What does your Pull Request do (check all that apply)?

Description of changes

Which issues (if any) does this fix?

People to notify (@mention interested parties)

Choose a reason for hiding this comment

manrajgrover Jun 16, 2016 • edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

manrajgrover commented Jun 16, 2016

sahildua2305 commented Jun 16, 2016

manrajgrover commented Jun 16, 2016

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

daxtheduck commented Jun 16, 2016

Choose a reason for hiding this comment

zekiel commented Jun 17, 2016

manrajgrover commented Jun 17, 2016

jophab Jun 17, 2016 • edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

nalinbhardwaj commented Jun 18, 2016

manrajgrover commented Jun 18, 2016

nalinbhardwaj commented Jun 18, 2016

manrajgrover commented Jun 18, 2016

zekiel commented Jun 20, 2016

manrajgrover commented Jun 20, 2016

zekiel commented Jun 21, 2016

manrajgrover commented Jun 21, 2016

manrajgrover commented Jun 23, 2016

daxtheduck commented Jun 23, 2016

manrajgrover commented Jun 16, 2016 •

edited

manrajgrover Jun 16, 2016 •

edited

jophab Jun 17, 2016 •

edited