This repository has been archived by the owner on Oct 15, 2022. It is now read-only.
Remove html_enc from few IA Goodies
#3568
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| title => html_enc($message), | ||
| subtitle => 'Email address validation: '.html_enc($address) | ||
| title => $message, | ||
| subtitle => 'Email address validation: '.$address |
There was a problem hiding this comment.
Want to switch this to Email address validation: $address" while you're at it?
And any others now enabled too 😄
There was a problem hiding this comment.
@GuiltyDolphin Sure 😄 Thanks for pointing it out!
|
@GuiltyDolphin The build stopped midway. Could you please look into it? 😄 |
|
@manrajgrover Still an issue? Build seems to have finished from what I can tell. |
|
@GuiltyDolphin Nope, looks like someone else restarted it. |
|
@GuiltyDolphin I guess we can merge this |
| @@ -43,7 +43,7 @@ handle remainder => sub { | |||
| return unless $info; | |||
| my (@vendor) = split(/\\n/, $info, 2); | |||
|
|
|||
| my ($name, $addr) = map { html_enc($_); } @vendor; | |||
| my ($name, $addr) = map { $_; } @vendor; | |||
There was a problem hiding this comment.
A.k.a @vendor (mapping the identity is the same as the list).
There was a problem hiding this comment.
@GuiltyDolphin Fixed :)
|
@manrajgrover Thanks! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does your Pull Request do (check all that apply)?
Choose the most relevant items and use the following title template to name
your Pull Request.
New {Cheat Sheet Name} Cheat SheetNew {IA Name} Instant Answer{More than 1}: Fix {Removes html_enc}{IA Name}: {Description of Improvements}{GoodieRole/Templates/Tests/Docs}: {Short Description}Description of changes
Remove
html_encfrom few IA GoodiesWhich issues (if any) does this fix?
#3563
People to notify (@mention interested parties)
@moollaza
Instant Answer Page:
Maintainer: @mention
None