Skip to content
This repository has been archived by the owner on Oct 15, 2022. It is now read-only.

Dice: Fixes size of utf-8 display dices #4013

Merged
merged 2 commits into from Mar 18, 2017

Conversation

nalinbhardwaj
Copy link
Contributor

@nalinbhardwaj nalinbhardwaj commented Mar 16, 2017

Description of new Instant Answer, or changes

Fixes dice size to improve readability of utf-8 dice icons. Properly tested across platforms this time. See screenshots for comparisons:

Old:
screen shot 2017-03-16 at 7 45 09 pm

New(proposed):
screen shot 2017-03-16 at 7 45 00 pm

Related Issues and Discussions

Fixes issues from #3886

People to notify

@loganom @moollaza

Testing & Review

To be completed by Community Leader (or DDG Staff) when reviewing Pull Request

Pull Request

  • Title follows correct format (Specifies Instant Answer + Purpose)
  • Description contains a valid Instant Answer Page Link (e.g. https://duck.co/ia/view/my_ia)

Instant Answer Page (for new Instant Answers)

  • Instant Answer page is correctly filled out and contains:
    • The Title is appropriately named and formatted
    • The IA topics are present and appropriate
    • The Description is clear and coherent
    • Source Name exists if applicable
    • All Example Queries trigger on Beta

Code

  • Adheres to the DuckDuckGo Style Guide
  • Behaviour is appropriately tested. If improvement, tests are adequately extended.
  • There is no unnecessary files in place (such as editor config files)
  • There is no API keys / secrets present
  • Tests are passing (run $ duckpan test <fathead_id>)
    • Tester should report any failures

Ready to merge?

  • Has this IA been deployed to and tested on beta.duckduckgo.com?
  • For larger commits, has this been approved be more than one community member?
  • The number of reviews is appropriate for this type of PR
  • The commit message is clear, coherent and fitting

Pull Request Review Guidelines: https://docs.duckduckhack.com/programming-mission/pr-review.html


Instant Answer Page: https://duck.co/ia/view/dice

@daxtheduck
Copy link

daxtheduck commented Mar 16, 2017

Dice

Description: Give the results of a random die throw with one or more dice

Example Query: throw dice, roll 5 dice, roll 3d12, roll 3d12 and 2d4, roll 2 dice and 3d5, throw a die

Tab Name: Answer

Source:

These are the important fields from the IA page. Please check these for errors or missing information and update the IA page


This is an automated message which will be updated as changes are made to the IA page

@loganom
Copy link
Collaborator

loganom commented Mar 17, 2017

Thanks @nalinbhardwaj / @gautamkrishnar

@gautamkrishnar
Copy link
Collaborator

@loganom is this ok to merge?

@mintsoft
Copy link
Collaborator

Thanks @nalinbhardwaj @loganom @gautamkrishnar

@mintsoft mintsoft merged commit 7afb399 into duckduckgo:master Mar 18, 2017
@nalinbhardwaj nalinbhardwaj deleted the dice-size-fix branch April 10, 2017 11:37
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants