Skip to content
This repository has been archived by the owner on Oct 15, 2022. It is now read-only.

html_entities: Added new triggers & tests #4203

Merged
merged 2 commits into from May 22, 2017
Merged

html_entities: Added new triggers & tests #4203

merged 2 commits into from May 22, 2017

Conversation

Owlree
Copy link
Collaborator

@Owlree Owlree commented May 13, 2017

Description of new Instant Answer, or changes

Adds new triggers and tests for the html entities goodie.

Related Issues and Discussions

Fixes #4086.

People to notify

Hey, @moollaza, I made another PR since I deleted the previous branch by accident, sorry. I implemented the changes we talked about.

Testing & Review

To be completed by Community Leader (or DDG Staff) when reviewing Pull Request

Pull Request

  • Title follows correct format (Specifies Instant Answer + Purpose)
  • Description contains a valid Instant Answer Page Link (e.g. https://duck.co/ia/view/my_ia)

Instant Answer Page (for new Instant Answers)

  • Instant Answer page is correctly filled out and contains:
    • The Title is appropriately named and formatted
    • The IA topics are present and appropriate
    • The Description is clear and coherent
    • Source Name exists if applicable
    • All Example Queries trigger on Beta

Code

  • Adheres to the DuckDuckGo Style Guide
  • Behaviour is appropriately tested. If improvement, tests are adequately extended.
  • There is no unnecessary files in place (such as editor config files)
  • There is no API keys / secrets present
  • Tests are passing (run $ duckpan test <goodie_id>)
    • Tester should report any failures

Ready to merge?

  • Has this IA been deployed to and tested on beta.duckduckgo.com?
  • For larger commits, has this been approved be more than one community member?
  • The number of reviews is appropriate for this type of PR
  • The commit message is clear, coherent and fitting

Pull Request Review Guidelines: https://docs.duckduckhack.com/programming-mission/pr-review.html


Instant Answer Page: https://duck.co/ia/view/html_entities

@daxtheduck
Copy link

daxtheduck commented May 13, 2017

HTML Entities

Description: A table of HTML entities

Example Query: html entities

Tab Name: Answer

Source: https://dev.w3.org/html5/html-author/charref

These are the important fields from the IA page. Please check these for errors or missing information and update the IA page


This is an automated message which will be updated as changes are made to the IA page

@moollaza
Copy link
Member

@Owlree Thanks! This LGTM 👍

@moollaza moollaza merged commit a588c17 into duckduckgo:master May 22, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

HTML Entities: Add additional trigger words
4 participants