This repository has been archived by the owner on Oct 15, 2022. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 1.8k
Timezones #4460
Closed
Closed
Timezones #4460
Changes from 14 commits
Commits
Show all changes
19 commits
Select commit
Hold shift + click to select a range
6b19898
adding aptitude cheat sheet
30c7529
Coherence between section list and sections
8ed11d7
minor typo
c5ecf43
added a link towards Debian reference
d194eff
Merge remote-tracking branch 'upstream/master'
627e817
Added a yaml file containing timezone abbreviations.
d7daf6d
Added ambiguities management.
e44edbc
Added subtemplate.
d51988d
Added some style.
82ac14e
Added UTC offset.
48de83d
Added some metainfo.
3e247dd
Fixed BEM notation.
2517387
Added a copy of a datetime object instead of creating a new one at
e263d31
Fixed tests.
9db2d48
Added conversion of offsets.
9394643
Added date to avoid confusion.
2e79ff0
Fixed css.
a1481b5
Fixed tests.
8f35188
Fixed tests. Now using different times.
File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this might be clearer as a
for
loop rather than a map, with the multiple statements within it's pretty difficult to readThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm also it might be worth building this outside of the handle so we can just just lookup the answer?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll rewrite it using a for loop with a push inside.
Yes, we can convert offsets only once for each timezone. I'll fix this too.