Timezone Coverter: Removed friendly "Noon" and "Midnight" times from TimezoneConverter IA

[tossj]

Description of new Instant Answer, or changes

Timezone Converter would previously show the converted times 12 PM and 0 AM as "Noon" and "Midnight", respectively. This PR changes the instant answer so 12 PM and 0 AM are always shown in the same time format as all other times.

Related Issues and Discussions

Fixes #1451

People to notify

@moollaza @mintsoft

---

Instant Answer Page: https://duck.co/ia/view/timezone_converter

[daxtheduck]

Timezone Converter

Description: convert times between timezones

Example Query: 10:00AM MST to PST, 19:00 UTC to EST, 1am UTC to PST

Tab Name: Answer

Source:

These are the important fields from the IA page. Please check these for errors or missing information and update the IA page

---

This is an automated message which will be updated as changes are made to the IA page

[mintsoft]

@tossj We chose to use noon and midnight here to disambiguate for users. Not all people are aware around the rules for AM/PM vs 0/12; is there a specific reason you think this should be changed?

Edit: Apologies, I totally forgot about that issue. I think we want both the time and noon/midnight on the output, so it has the best of both worlds.

[tossj]

@mintsoft Would it be fine if on a query like 12pm UTC into GMT it gives output Noon - 12:00 PM GMT?

Also, with this current fix a query such as 0am UTC into GMT gives output Midnight - 0:00 AM GMT, but if AM is present the time should be 12:00. Would that be a separate issue, or can I fix it in this PR?

[mintsoft]

It makes sense to fix it in this PR

[moollaza]

Deploying to Beta

[moollaza]

@tossj @mintsoft Thanks! This LGTM 👍

I noticed one oddity though: 3:00 est to pst shows 0:00 PST -- is it intended to show midnight - 0:00 PST?

[tossj]

@moollaza The existing code only added Midnight or Noon when am or pm was present in the query. Should they also be added for 24-hour clock times, or is it already implied?