Conversions fix #4506
Conversions fix #4506
Conversation
ConversionsDescription: convert between various units of measurement Example Query: convert 5 oz to grams, 5 ounces to g, 0.5 nautical miles in km Tab Name: Answer Source: These are the important fields from the IA page. Please check these for errors or missing information and update the IA page This is an automated message which will be updated as changes are made to the IA page |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See comments.
@@ -695,6 +695,22 @@ ddg_goodie_test( | |||
physical_quantity => 'length' | |||
}) | |||
), | |||
'how many metres are in 10 yards?' => test_zci( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the original problem is that they do already trigger on are in
, but not in
. This test should be how many metres in 10 yards?
You can get rid of the test below and a couple more like this that aren't metres / yards.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this question good ? how many kilobytes are in 2Tb?
That regexp doesn't match it, because prefix-left_num are in
is not followed by a
. You can only write something like how many bytes are in a kilobyte?
but not how many bytes are in kilobyte?
If you omit "a" after are in
in your request, regexp doesn't match and nothing triggers. But you can write this how many tsp are in a 1 tbsp
and it triggers and even gives correct result. So, you can just add ?-quatifier after the corresponding a
letter at regexp and it will give chance to people with bad english to know, how many bytes are in kilobyte or in 2 kilobytes.
Merging to my own branch to test + continue as original branch no longer exists |
Conversions
Description of new Instant Answer, or changes
now conversions IA can answer at questions, composed not only like this "how many metres [are] in a mile?" but also like this "how many metres are there in a mile?" or "how many metres are in 2 miles?".
Related Issues and Discussions
Fixes #4502 Fixed #4501
People to notify
Instant Answer Page: https://duck.co/ia/view/conversions