Skip to content
This repository has been archived by the owner on Oct 15, 2022. It is now read-only.

Currency: Better triggers for precious metals #1421

Closed
moollaza opened this issue Jan 16, 2015 · 7 comments
Closed

Currency: Better triggers for precious metals #1421

moollaza opened this issue Jan 16, 2015 · 7 comments

Comments

@moollaza
Copy link
Member

moollaza commented Jan 16, 2015

https://duck.co/ideas/idea/4797/add-commodities-to-valuta-ratios

Right now you must use the ISO 4217 codes to indicated Gold, Silver, Platinum and Palladium. We should add some logic to except those names and related terms like "ounce", "ounces", "oz", so we can handle queries like "1oz Gold in USD"


IA Page: https://duck.co/ia/view/currency

@p-kankowski
Copy link
Contributor

@moollaza "Gold price", "gold prices today", and "gold price per ounce" sound more natural and that's what people usually search for (according to search suggestions).

@moollaza
Copy link
Member Author

@w25 I agree! all of those are excellent triggers that this IA should be able to detect

@gabhi
Copy link

gabhi commented Mar 6, 2016

@moollaza I would like to work on this issue.

@gabhi
Copy link

gabhi commented Mar 9, 2016

@moollaza do you which API can i use to get the results?

@MrChrisW
Copy link
Collaborator

MrChrisW commented Mar 9, 2016

@gabhi You will be able to use the existing XE.com API which is included in the currency IA. See https://github.com/duckduckgo/zeroclickinfo-spice/blob/master/lib/DDG/Spice/Currency.pm#L38

@gabhi
Copy link

gabhi commented Mar 9, 2016

Thanks @MrChrisW

@gabhi
Copy link

gabhi commented Mar 10, 2016

@moollaza @MrChrisW I created a pull request #2564. Can you please have a look at it?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

6 participants