Skip to content
This repository has been archived by the owner on Oct 15, 2022. It is now read-only.

Added IA for gold prices #2564

Closed
wants to merge 1 commit into from
Closed

Added IA for gold prices #2564

wants to merge 1 commit into from

Conversation

gabhi
Copy link

@gabhi gabhi commented Mar 10, 2016 •
edited by jdorweiler

@daxtheduck
Copy link

@gabhi Hey!

Thanks for taking the time to contribute! We really appreciate it.

We work closely with every contributor to make Instant Answers the best they can be, so we appreciate your patience as we look over your code. From here, the process usually goes like this:

  1. Pull Request is reviewed by the DuckDuckGo staff and community
  2. Staff and community will leave feedback with any necessary updates to the function or design.
  3. Once you've made any necessary corrections, then your Instant Answer will be merged and deployed live on DuckDuckGo!

If you have any questions along the way, feel free to ask them here. Our staff and community are also available on Slack to answer any questions you may have. If you'd like to join us there please send an email to quackslack@duckduckgo.com.

More Info: https://duck.co/duckduckhack/submission_and_review

Thanks!

@daxtheduck
Copy link

Currency

Description: Currency Convertor provided by XE.com

Example Query: [convert 499 usd to cad](https://beta.duckduckgo.com/?q=convert 499 usd to cad), [cad to usd](https://beta.duckduckgo.com/?q=cad to usd), cny?

Tab Name: Currency

Source:

These are the important fields from the IA page. Please check these for errors or missing information and update the IA page

This is an automated message which will be updated as changes are made to the IA page

@gabhi gabhi mentioned this pull request Mar 10, 2016
Closed
moollaza
moollaza reviewed Mar 10, 2016
View reviewed changes
share/spice/currency/currencyNames.txt
@@ -156,7 +156,7 @@ vuv,ni-vanuatu vatu,vanuatu vatu,
wst,samoan tala,samoa tala,
xaf,central african cfa franc beac,re africaine cfa franc beac,
xag,silver ounce,silver,
xau,gold ounce,gold,
xau,gold ounce,gold,1 oz gold in usd,gold price,gold prices today,gold price per ounce,1oz gold,1oz gold in usd
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gabhi when updating triggers, it's always good to update test. In this case adding some tests that ensure the changes work 👍

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@moollaza my bad. Totally forgot.

Added test case. Can you please review this pull request?

@gabhi
Copy link
Author

gabhi commented Mar 28, 2016

@moollaza @MrChrisW Looks like i might need some more help here.i m confused with natural words like prices today, x oz which do not exactly follow the pattern for currency. would you like to give some more pointers on this PR?

@jdorweiler
Copy link
Contributor

@gabhi cold your update your branch? It has some conflicts now.
@MrChrisW can you review or help @gabhi?

@moollaza
Copy link
Member

This PR is being closed due to inactivity. It looks like most of this now triggers the Instant Answer

@moollaza moollaza closed this Jun 21, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees

@MrChrisW MrChrisW

Labels
Improvement Status: On Hold Status: Work In Progress Triggering
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@gabhi @daxtheduck @jdorweiler @moollaza @MrChrisW @nilnilnil