Skip to content
This repository has been archived by the owner on Oct 15, 2022. It is now read-only.
This repository has been archived by the owner on Oct 15, 2022. It is now read-only.

Snow: Impove snowflake effect #1562

Closed
moollaza opened this issue Feb 23, 2015 · 9 comments · Fixed by #1940
Closed

Snow: Impove snowflake effect #1562

moollaza opened this issue Feb 23, 2015 · 9 comments · Fixed by #1940

Comments

@moollaza
Copy link
Member

http://php.quicoto.com/snow-html-canvas/, Demo: http://php.quicoto.com/examples/27/

This is more of the effect we'd like to see (simplified snowflakes, smaller).

Also, let's try 700 particles and update the background colour of the IA to #D0D0D0

https://duck.co/ia/view/snow

@jagtalon
Copy link
Member

👍 the snow oscillates pretty quickly as well. http://cl.ly/0J1J1K012L0v. Almost as if the snow flakes are shivering.

@jagtalon jagtalon changed the title IsItSnowing: Impove snowflake effect Snow: Impove snowflake effect Feb 28, 2015
@gokul1794
Copy link
Contributor

Is anyone working on this?

@moollaza
Copy link
Member Author

@gokul1794 nope 👍

@gokul1794
Copy link
Contributor

I get this, so how do I test what I do?
API key not found. Using DuckDuckGo's endpoint:
"https://ddh1.duckduckgo.com/js/spice/snow/Phoenixville%2CPennsylvania%2CUnited%20States"
"500 Can't connect to ddh1.duckduckgo.com:443 (Connection refused)"

@MrChrisW
Copy link
Collaborator

@gokul1794 The issue here is that the API_KEY doesn't exist an an env var on your system so the faillback API is used, in this case ddh1.duckduckgo.com.

I've experienced a similar issue with DuckPan failing back to the ddh1 endpoint which is currently not active, @moollaza fix?

The workaround is to plug https://duckduckgo.com/js/spice/snow/$1 into the spice to value on line 20 Snow.pm for testing purposes only.

@gokul1794
Copy link
Contributor

Thanks @MrChrisW. That seems to work!

@gokul1794
Copy link
Contributor

var snowContainer = document.querySelector('.zci-wrap');
I changed the class to be called to .zci-wrap and added

.zci-wrap{
    height: 150px;
}

for testing purposes, not too sure why it isn't working :/

@gokul1794
Copy link
Contributor

@moollaza document.querySelector('.zci.zci--snow.is-active) returns null. This is where we want the snowflakes to be shown right?

@gokul1794
Copy link
Contributor

Ok i got this to work, Will make a PR soon :)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants