BrainyQuote: Double quotes missing at end

[killerfish]

Ending quote is missing, SS below

@jagtalon @chrismorast are we still aiming for proposed design changes? in #674

---

IA Page: https://duck.co/ia/view/brainy_quote

[chrismorast]

@killerfish , I believe there were some issues in rendering both quotes. Don't entirely remember what they were :) but I think it was related to alignment.

[killerfish]

How about we use png, instead of entities for the quotes? e.g.

[moollaza]

We discussed it a bunch and ended up deciding to remove the trailing quote here: #951

[moollaza]

If @chrismorast would like it to be re-designed we can open this up again for discussion, otherwise I've marked this as tolerated.

[chrismorast]

Ahh, yes. Removing the last quote had to do with it breaking the line height on the last line.

[killerfish]

So @chrismorast do you think we can have a way around this (not using entities etc), or do we close this?

[chrismorast]

@killerfish , do you think we can add the quote without compromising the line height? It would be great to do something along these lines:

The top of the end quote would align to the tom of the corresponding line of text. Also, margin matching is represented in the yellow blocks.

Do you think this would be doable? If so, can we squeeze one other update in there. Can we add 'text--primary' to the quote so it renders in # 333 rather than # 666?

[MrChrisW]

I'd like to add to this discussion and bring up the issue of spacing, when a single line quote is displayed the brainy__quote--container takes up to much space!

[killerfish]

Thanks @MrChrisW, ill account for that issue.

[chrismorast]

Good catch @MrChrisW !

[MrChrisW]

@killerfish 😄 Hope you're doing well! Have you had a chance to look into these issues?

[killerfish]

@MrChrisW sorry this got delayed, been MIA, ill start looking into issues this weekend ^^

[killerfish]

@chrismorast could you tell me what color, size etc preferences you have for the quotes + text, so i could switch to that. Line height seems to be good now.

[chrismorast]

Thanks @killerfish , this is looking a lot better!

As far as color and size goes, can you use #d0d0d0 for the color and bring them to about 80% of the size they are in the screenshot you posted above? Here's what that would look like. (I also reduced the spacing between the quote asset and the text a bit)