Skip to content
This repository has been archived by the owner on Oct 15, 2022. It is now read-only.
This repository has been archived by the owner on Oct 15, 2022. It is now read-only.

Dictionary: "define fungi" shows two play buttons #2609

Closed
jagtalon opened this issue Mar 21, 2016 · 4 comments
Closed

Dictionary: "define fungi" shows two play buttons #2609

jagtalon opened this issue Mar 21, 2016 · 4 comments

Comments

@jagtalon
Copy link
Member

And they're in the subtitle--it should be right beside the title.

https://duckduckgo.com/?q=define+fungi&ia=definition
screen shot 2016-03-21 at 9 58 58 am


https://duck.co/ia/view/dictionary_definition
Maintainer: @jagtalon

@moollaza
Copy link
Member

Hey @duckduckgo/duckduckhack-active-contributors! Anyone interested in fixing this issue?

If so, comment here to let us know and we'll assign the task to you so everyone knows what's going on.

It'll require a bit of JS knowledge. We had made some changes the the DDG Playbutton for the Forvo Spice and I think this IA will need some adjustments as a result.

A good place to start looking is here: https://github.com/duckduckgo/zeroclickinfo-spice/blob/master/share/spice/dictionary/definition/dictionary_definition.js#L187

@marianosimone
Copy link
Collaborator

@moollaza: I'd love to take a look. However, it seems like in my dev environment only 1 play button is shown (working from codio, with latest duckpan installed)

@moollaza
Copy link
Member

moollaza commented Apr 4, 2016

@marianosimone it looks like we're making a secondary API call in production for fungus. We should probably add a check that if a player exists on the page, we shouldn't add another?

@tagawa
Copy link
Collaborator

tagawa commented May 28, 2016

Fixed internally.

@tagawa tagawa closed this as completed May 28, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

5 participants