This repository has been archived by the owner on Oct 15, 2022. It is now read-only.
Fix Rainfall tests for travis #1589
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some variants of the country data report Bolivia as
Bolivia, Plurinational State of
(comma after 'Bolivia') while others use
Bolivia (Plurinational State of)
(space and opening paren after 'Bolivia').
This difference recently made made travis tests fail [1]. We now split
country names at both comma and ' (' to identify the main country name
for both variants. Thereby, tests pass again in travis.
[1] https://travis-ci.org/duckduckgo/zeroclickinfo-spice/jobs/52748092#L1663
|
Travis is all green again :-) |
|
@pfirsichbluete thanks for this! We'll review shortly. /cc @MrChrisW thought you'd be interested in this :) |
|
Just for reference ... Last good build I found was https://travis-ci.org/duckduckgo/zeroclickinfo-spice/builds/51509283 First bad build I found was https://travis-ci.org/duckduckgo/zeroclickinfo-spice/builds/52748091 |
|
LGTM 👍 @pfirsichbluete thanks a lot! |
|
@moollaza Thanks for the ping on this! Interesting to see an upstream package update break my code 😃 Thanks for the fix @pfirsichbluete |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Recently Travis started to fail Rainfall tests.
Those two commits make them pass again.
The first commit is just whitespace fixup.
The second commit has the acutal fix.
The issue is that some variants of the country data report Bolivia as
(comma after 'Bolivia') while others use
(space and opening paren after 'Bolivia').
This difference recently made made travis tests fail. We now split
country names at both comma and ' (' to identify the main country name
for both variants. Thereby, tests pass again in travis.