Bible : Show Random Verse #2826

rajeshwarisah · 2016-06-16T11:53:46Z

Fixes #2820 - adds trigger to random and shows random verses
#2820
https://duck.co/ia/view/bible
@hunterlang

daxtheduck · 2016-06-16T11:53:47Z

@MAMAMIA9 Hey!

Thanks for taking the time to contribute! We really appreciate it.

We work closely with every contributor to make Instant Answers the best they can be, so we appreciate your patience as we look over your code. From here, the process usually goes like this:

Pull Request is reviewed by the DuckDuckGo staff and community
Staff and community will leave feedback with any necessary updates to the function or design.
Once you've made any necessary corrections, then your Instant Answer will be merged and deployed live on DuckDuckGo!

If you have any questions along the way, feel free to ask them here. Our staff and community are also available on Slack to answer any questions you may have. If you'd like to join us there please head to https://quackslack.herokuapp.com/ to get an invite.

More Info: http://docs.duckduckhack.com/submitting/submitting-overview.html

Thanks!

daxtheduck · 2016-06-16T11:53:47Z

Bible

Description: Provides the text of selected Bible verses from the NET Bible translation.

Example Query: [genesis 15:7](https://beta.duckduckgo.com/?q=genesis 15:7), [bible genesis 26:4](https://beta.duckduckgo.com/?q=bible genesis 26:4)

Tab Name: Answer

Source:

These are the important fields from the IA page. Please check these for errors or missing information and update the IA page

This is an automated message which will be updated as changes are made to the IA page

tagawa · 2016-06-16T12:02:26Z

lib/DDG/Spice/Bible.pm

@@ -12,6 +12,9 @@ spice to => 'http://labs.bible.org/api/?type=json&callback={{callback}}&formatti
 handle query_lc => sub {
    if ($_ =~ /^bible\s+([a-z]+\s*?[0-9]+:[0-9]+)$/i || $_ =~ /^((?:genesis|exodus|leviticus|numbers|deuteronomy|joshua|judges|ruth|1 samuel|2 samuel|1 kings|2 kings|1 chronicles|2 chronicles|ezra|nehemiah|esther|job|psalm|proverbs|ecclesiastes|song of solomon|isaiah|jeremiah|lamentations|ezekiel|daniel|hosea|joel|amos|obadiah|jonah|micah|nahum|habakkuk|zephaniah|haggai|zechariah|malachi|matthew|mark|luke|john|acts|romans|1 corinthians|2 corinthians|galatians|ephesians|philippians|colossians|1 thessalonians|2 thessalonians|1 timothy|2 timothy|titus|philemon|hebrews|james|1 peter|2 peter|1 john|2 john|3 john|jude|revelation)\s+[0-9]+:[0-9]+)$/) {
        return $1 if $1;
+    }   
+    if ($_ =~ /^bible\s+(?:random|random verse)$/i){


Please could you put a space between ) and {

pnpninja · 2016-06-16T12:35:20Z

@tagawa : is it necessary that @hunterlang give some input on this?

tagawa · 2016-06-16T12:36:37Z

@pnpninja Yes, I'm going to deploy to beta soon (there's currently a separate install in progress) and then we can test it - both the maintainer and community.

pnpninja · 2016-06-16T12:37:17Z

@tagawa : sweet! thanks bro

tagawa · 2016-06-16T13:53:18Z

It's here on the beta server now: https://beta.duckduckgo.com/?q=bible+random+verse&ia=answer
Good, quick work @MAMAMIA9!

One thing I've noticed is that it would be good if it also appeared for random bible verse. Do you think it's possible to add that?

tagawa · 2016-06-16T13:54:22Z

Actually, maybe even random verse bible and random verse from the bible, but maybe that would be pushing the regex too far :-)

pnpninja · 2016-06-17T05:42:09Z

@tagawa : we'll see what we can do...

Added additional triggers

More triggers

Added additional tests for additional triggers that are getting accepted

pnpninja · 2016-06-17T06:03:27Z

@tagawa : added additional triggers and the tests...

pnpninja · 2016-06-17T07:38:01Z

@tagawa : looking all good in the Beta 🤘🏼

tagawa · 2016-06-17T07:57:28Z

Yay! random bible verse seems to be a popular query so this is a really nice improvement.
Let's leave it on beta for the community to test before we merge this.

tagawa · 2016-06-17T08:52:49Z

One thing I've just noticed - with the query random bible verse I'm getting the About tab opening, and I have to click on the Answer tab to make this IA visible. To increase the priority of this IA, please could you add this line to the meta object within Spice.add in the share/spice/bible/bible.js file?

signal: 'high'

Set signal to high to prevent some Fathead from triggering on `random bible verse` query

pnpninja · 2016-06-17T09:23:14Z

@tagawa : oh yea - i saw it... I think i've fixed it ...

tagawa · 2016-06-17T10:13:02Z

share/spice/bible/bible.js

@@ -17,7 +17,8 @@
            meta: {
                sourceName: 'Bible',
                sourceUrl: source_url,
-                sourceIconUrl: 'http://bible.org/sites/bible.org/files/borg6_favicon.ico'
+                sourceIconUrl: 'http://bible.org/sites/bible.org/files/borg6_favicon.ico',
+                signal: 'high'


Ah, you were right first time. This should be above the meta object, next to id, name, etc. Sorry!

tagawa · 2016-06-17T11:37:44Z

Thanks @pnpninja - this works for me now. How about you?

pnpninja · 2016-06-17T12:09:34Z

@tagawa - yup ! it works

tagawa · 2016-06-17T13:00:42Z

@MAMAMIA9 @pnpninja: @zekiel noticed that we're caching the API result (it's on by default for one hour). Did you have trouble with their API limits when you turned it off during testing? If so, could we try adding a line in Bible.pm to cache for, say 5 minutes, e.g.

spice proxy_cache_valid => "200 5m";

More info about caching: http://docs.duckduckhack.com/backend-reference/api-reference.html

pnpninja · 2016-06-17T14:48:40Z

@tagawa - yes. sometimes, we get a 500 error.. I think its best we cache for 5 min.. I'll do it

gaulrobe · 2016-06-17T14:59:37Z

@MAMAMIA9 @pnpninja @tagawa Any kind of caching when there is a "random" query might cause user frustration right? Ideally, we don't want to cache those so that people have a true, random experience?

tagawa · 2016-06-17T15:01:45Z

@gaulrobe We'd likely get a 500 error from the API if there's no caching, but then the user wouldn't see the error - just no IA would appear. So it's a choice between that or possible repeated IA content. What do we think is best?

gaulrobe · 2016-06-17T15:08:07Z

@tagawa could we refactor this IA to be two separate modules/tests? One for random verses, which isn't cached and the other for specific bible verses which can probably be cached for a long time. Is that something we can do here?

tagawa · 2016-06-17T16:46:21Z

@moollaza Do you know if what @gaulrobe is suggesting is possible within a single IA?

tagawa · 2016-06-20T09:40:59Z

@gaulrobe True.

@moollaza What do you reckon? I think we have three options:

Don't cache, and accept that the IA won't appear sometimes, both for random and non-random queries.
Cache, and accept that people will see a repeated result if they repeat the search.
Split the IA into two - one which caches and one which doesn't.

pnpninja · 2016-06-21T10:28:52Z

ping @moollaza

moollaza · 2016-06-21T15:52:30Z

share/spice/bible/bible.js

@@ -14,6 +14,7 @@
            id: 'bible',
            name: 'Answer',
            data: result,
+            signal: 'high',


We should first try to handle this with the Block Group on the IA Page.

@tagawa recently @bsstoner told me we should't set the signal "high" like this because it can confuse the AnswerBar JS.

Ah, OK. So for IAs that aren't appearing as the default tab but should be, we should set it internally instead?

moollaza · 2016-06-21T15:52:41Z

@moollaza What do you reckon? I think we have three options:

I don't understand why we're seeing any 500 responses? That seems like a bigger problem.

Given the nature of the "Random Verse" IA -- I think it's best to make this into a separate IA. We shouldn't sacrifice the speed and caching of the existing IA to support the random Bible verses results. The alternative, a Random IA that is only random every 5 minutes will probably give the impression that it's broken.

We will need to namespace them accordingly: e.g. DDG::Spice::Bible::Lookup and DDG::Spice::Bible::Random. That will need to be two separate PRs. One for updating the current Spice, another adding the new one.

tagawa · 2016-06-22T07:13:44Z

@MAMAMIA9 @pnpninja Sorry but could we make this into a new Instant Answer after all? It can re-use the code you've written, and the regex would be a lot simpler. Also:

The main file should be renamed to Random.pm and put in a new lib/DDG/Spice/Bible directory
The namespace at the top of that file should be DDG::Spice::Bible::Random

I think the test file and JS file are OK as they are.

moollaza · 2017-07-10T21:35:21Z

This PR is being closed due to inactivity. If you're still interested in finishing, please let me know and I'll gladly re-open it for you!

rajeshwarisah added 4 commits June 16, 2016 08:17

New Random Bible Verse Spice

0608800

New Random Bible Verse Spice

f2e4135

New Random Bible Verse Spice

aeddfeb

New Random Bible Verse Spice

9b87592

daxtheduck added the Maintainer Input Requested label Jun 16, 2016

tagawa reviewed Jun 16, 2016
View reviewed changes

rajeshwarisah added 2 commits June 16, 2016 17:43

Update Bible.pm

947f76d

Update Bible.pm

a38e7c1

daxtheduck deployed to beta.duckduckgo.com June 16, 2016 13:17 Active

tagawa added Improvement Status: Needs Community Review labels Jun 16, 2016

pnpninja added 3 commits June 17, 2016 11:30

Update Bible.pm

f8fa164

Added additional triggers

Update triggers.txt

d75f12c

More triggers

Update Bible.t

3e6e3f2

Added additional tests for additional triggers that are getting accepted

daxtheduck deployed to beta.duckduckgo.com June 17, 2016 07:03 Active

Update bible.js

1112459

Set signal to high to prevent some Fathead from triggering on `random bible verse` query

daxtheduck deployed to beta.duckduckgo.com June 17, 2016 09:50 Active

Update bible.js

09b0fa1

tagawa reviewed Jun 17, 2016
View reviewed changes

Update bible.js

9fee536

daxtheduck deployed to beta.duckduckgo.com June 17, 2016 11:29 Active

moollaza reviewed Jun 21, 2016
View reviewed changes

pnpninja mentioned this pull request Jul 31, 2016

Bible verse of the day #2929

Closed

gerlachry mentioned this pull request Aug 3, 2016

Bible: adding verse of the day #2936

Merged

6 tasks

moollaza closed this Jul 10, 2017

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Bible : Show Random Verse #2826

Bible : Show Random Verse #2826

rajeshwarisah commented Jun 16, 2016

daxtheduck commented Jun 16, 2016

daxtheduck commented Jun 16, 2016 •

edited

tagawa Jun 16, 2016

pnpninja commented Jun 16, 2016

tagawa commented Jun 16, 2016

pnpninja commented Jun 16, 2016

tagawa commented Jun 16, 2016

tagawa commented Jun 16, 2016

pnpninja commented Jun 17, 2016

pnpninja commented Jun 17, 2016

pnpninja commented Jun 17, 2016

tagawa commented Jun 17, 2016

tagawa commented Jun 17, 2016

pnpninja commented Jun 17, 2016

tagawa Jun 17, 2016

tagawa commented Jun 17, 2016

pnpninja commented Jun 17, 2016

tagawa commented Jun 17, 2016

pnpninja commented Jun 17, 2016 •

edited

gaulrobe commented Jun 17, 2016

tagawa commented Jun 17, 2016

gaulrobe commented Jun 17, 2016

tagawa commented Jun 17, 2016

tagawa commented Jun 20, 2016

pnpninja commented Jun 21, 2016

moollaza Jun 21, 2016

tagawa Jun 22, 2016

moollaza Jun 23, 2016

moollaza commented Jun 21, 2016

tagawa commented Jun 22, 2016

moollaza commented Jul 10, 2017

Bible : Show Random Verse #2826

Bible : Show Random Verse #2826

Conversation

rajeshwarisah commented Jun 16, 2016

daxtheduck commented Jun 16, 2016

daxtheduck commented Jun 16, 2016 • edited

Bible

tagawa Jun 16, 2016

Choose a reason for hiding this comment

pnpninja commented Jun 16, 2016

tagawa commented Jun 16, 2016

pnpninja commented Jun 16, 2016

tagawa commented Jun 16, 2016

tagawa commented Jun 16, 2016

pnpninja commented Jun 17, 2016

pnpninja commented Jun 17, 2016

pnpninja commented Jun 17, 2016

tagawa commented Jun 17, 2016

tagawa commented Jun 17, 2016

pnpninja commented Jun 17, 2016

tagawa Jun 17, 2016

Choose a reason for hiding this comment

tagawa commented Jun 17, 2016

pnpninja commented Jun 17, 2016

tagawa commented Jun 17, 2016

pnpninja commented Jun 17, 2016 • edited

gaulrobe commented Jun 17, 2016

tagawa commented Jun 17, 2016

gaulrobe commented Jun 17, 2016

tagawa commented Jun 17, 2016

tagawa commented Jun 20, 2016

pnpninja commented Jun 21, 2016

moollaza Jun 21, 2016

Choose a reason for hiding this comment

tagawa Jun 22, 2016

Choose a reason for hiding this comment

moollaza Jun 23, 2016

Choose a reason for hiding this comment

moollaza commented Jun 21, 2016

tagawa commented Jun 22, 2016

moollaza commented Jul 10, 2017

daxtheduck commented Jun 16, 2016 •

edited

pnpninja commented Jun 17, 2016 •

edited