BBC: Use image sizes closer to the display sizes, make signal high #667
Conversation
|
@TopHattedCoder Cool! @chrismorast What do you think about this? |
| @@ -45,6 +45,7 @@ | |||
| Spice.add({ | |||
| id: 'bbc', | |||
| name: 'BBC Shows', | |||
| signal: 'high', | |||
There was a problem hiding this comment.
@TopHattedCoder I haven't seen the key signal before. What does it do?
There was a problem hiding this comment.
@bradcater There are multiple IAs appearing at the same time. Setting signal to high will let us know which ones should show up first. :)
|
Hey, @TopHattedCoder. Here's the feedback from @chrismorast: These CSS changes should be good (make sure to prepend
The detail view should also display the time. It should be style exactly like the recipes. So:
|
|
I think we need to use the products_simple template group for this. Recipes' detail view is not a good example to copy. |
|
There were some changes to the way we handle tiles which is responsible for the merge conflict. Check out #680 for more details. :) |
|
Okay, I'll rebase the commits to be after the tile changes and see if that |
…time formatter function
|
@TomBebbington Sorry about the hassle, but we made a bunch of final changes before the launch last week. Is it okay if you merge master into your branch? |
|
Yeah, sure. On Fri, May 30, 2014 at 6:13 AM, Jag Talon notifications@github.com wrote:
|
| @@ -120,24 +110,8 @@ | |||
|
|
|||
|
|
|||
| // Find the programme image and return it | |||
| function image(item) { | |||
| return "http://ichef.bbci.co.uk/images/ic/272x153/" + (item.programme.image ? item.programme.image.pid : "legacy/episode/"+item.programme.pid) + ".jpg"; | |||
| function image(item, big) { | |||
There was a problem hiding this comment.
Nice! I like that we're choosing between sizes here.
|
@TomBebbington Sorry about closing this! We didn't see that there were PRs referencing the |
| }; | ||
| }, | ||
| templates: { | ||
| item: 'basic_image_item', | ||
| detail: Spice.bbc.detail, | ||
| group: 'products_simple', |
There was a problem hiding this comment.
This was renamed to the media template, but this still works.
This makes the detailed episode image bigger and the tiled episode smaller, and gives the spice a high signal because the triggers are very specific.
Old sizes
Desktop view
Mobile view
Wouldn't load...
Updated sizes
Desktop view
Mobile view