load_pyproject: Prefer the stdlib's TOML parser when available #344
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nbraud
force-pushed
the
toml
branch
5 times, most recently
from
2f4508d
to
0f43d16
Compare
|
This is cursed:
|
nbraud
added a commit
that referenced
this pull request
Nov 22, 2023
Noticed in #344: - `test_repo[bork]` runs `python -m bork` in a copy of the bork repo; - the Python interpreter looks for the `bork` module, finds the `bork/` folder in the (current) working directory; - the version of bork being run is the one `project_src` provided, rather than the one pytest was called against.
duckinator
pushed a commit
that referenced
this pull request
Nov 22, 2023
Noticed in #344: - `test_repo[bork]` runs `python -m bork` in a copy of the bork repo; - the Python interpreter looks for the `bork` module, finds the `bork/` folder in the (current) working directory; - the version of bork being run is the one `project_src` provided, rather than the one pytest was called against.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upstream development of the
tomlpackage seem to have mostly stalled back in 2020.Moreover, I'm not aware of any reason to prefer it over the stdlib's parser (introduced in Python 3.11) and that's one less dependency to care about. =^.^'=