Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make from_json parse ALL dates, not just some of them. #128

Merged
merged 3 commits into from Feb 9, 2017
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
11 changes: 11 additions & 0 deletions CHANGELOG.md
Expand Up @@ -9,6 +9,17 @@ this project adheres to [Semantic Versioning](http://semver.org).

(Nothing so far.)

## [v17.0.0]

This release ([snapshot](https://github.com/how-is/how_is/tree/v17.0.0))
makes `HowIs.from_json` parse _all_ dates, not just _some_ dates.
(Whoops.)

### Changes

* Make `HowIs.from_json` parse _all_ dates, not just some of them.
([#128](https://github.com/how-is/how_is/pull/128))

## [v16.0.0]

This release ([snapshot](https://github.com/how-is/how_is/tree/v16.0.0))
Expand Down
4 changes: 3 additions & 1 deletion lib/how_is/analyzer.rb
Expand Up @@ -62,7 +62,9 @@ def self.from_json(json)
[k, v]
end.to_h

%w[oldest_issue oldest_pull].each do |key|
hash.keys.each do |key|
next unless hash[key].is_a?(Hash) && hash[key]['date']

hash[key]['date'] = DateTime.parse(hash[key]['date'])
end

Expand Down
2 changes: 1 addition & 1 deletion lib/how_is/version.rb
@@ -1,3 +1,3 @@
class HowIs
VERSION = "16.0.0"
VERSION = "17.0.0"
end