Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[refact] remove nested if-else #258

Merged
merged 1 commit into from
Oct 9, 2023
Merged

[refact] remove nested if-else #258

merged 1 commit into from
Oct 9, 2023

Conversation

SergeiNA
Copy link
Collaborator

@SergeiNA SergeiNA commented Oct 7, 2023

  • remove heavy nested if-else
  • add new method in operate for ql type

@SergeiNA
[refact] remove nested if-else
494c1ae 
* remove heavy nested if-else
* add new method in operate for ql type
@SergeiNA
Copy link
Collaborator Author

SergeiNA commented Oct 7, 2023 •
edited

@kotbegemot sorry for this mess with additional formmating, but log lines doesn't fit my laptop screen. May be we should add some auto checks for clang-format in ou CI?

@SergeiNA
Copy link
Collaborator Author

SergeiNA commented Oct 7, 2023 •
edited

@kotbegemot why there no any CI tests on develop? Only for master?

SergeiNA
SergeiNA commented Oct 7, 2023
View reviewed changes
services/collection/collection.cpp
@@ -1,19 +1,20 @@
#include "collection.hpp"
Copy link
Collaborator Author

@SergeiNA SergeiNA Oct 7, 2023 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There two major changes:

  • add new method for operator_type
  • simplify if-else nested conditions in execute_plan
    All this can help me with moving insert_document into execute_plan

@kotbegemot kotbegemot self-requested a review October 9, 2023 19:29
@kotbegemot kotbegemot merged commit eadda9a into duckstax:develop Oct 9, 2023
@SergeiNA SergeiNA deleted the sn-heavy-nested-if-remove branch October 10, 2023 12:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kotbegemot kotbegemot kotbegemot approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@SergeiNA @kotbegemot