Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactoring: Move delete and update to execute ql #276

Merged
merged 1 commit into from
Dec 11, 2023

Conversation

SergeiNA
Copy link
Collaborator

@SergeiNA SergeiNA commented Dec 8, 2023

Previous PR

Summary: delete documents and update documents now work through the execute_ql

Related task: Insert, delete and update should be part of execute_q

Copy link
Collaborator

@makeyavelly makeyavelly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Like

services/dispatcher/dispatcher.hpp Outdated Show resolved Hide resolved
@kotbegemot kotbegemot self-requested a review December 11, 2023 13:12
@kotbegemot kotbegemot added the enhancement New feature or request label Dec 11, 2023
* All delete document logic moved into execute ql
* All update documen logic moved into execute ql
@SergeiNA SergeiNA merged commit 3aee70f into duckstax:develop Dec 11, 2023
9 checks passed
@SergeiNA SergeiNA deleted the sn-move-delete-to-execute-ql branch December 11, 2023 20:12
OrangeSmokingJacket added a commit to OrangeSmokingJacket/otterbrix that referenced this pull request Dec 12, 2023
OrangeSmokingJacket added a commit to OrangeSmokingJacket/otterbrix that referenced this pull request Dec 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants