[refactoring] remove find_sessoin with name #301
Conversation
services/dispatcher/dispatcher.cpp
Outdated
| @@ -468,7 +468,7 @@ namespace services::dispatcher { | |||
| collection_full_name_t key(index.database_, index.collection_); | |||
| auto it_collection = collection_address_book_.find(key); | |||
| if (it_collection != collection_address_book_.end()) { | |||
| make_session(session_to_address_, session_key_t{session, index.name()}, session_t(address, index)); | |||
| make_session(session_to_address_, session_key_t{session, {}}, session_t(address, index)); | |||
There was a problem hiding this comment.
maybe change make_session(session_to_address_, session_key_t{session, {}}, session_t(address, index)); -> make_session(session_to_address_, session_key_t{session}, session_t(address, index)); ?
There was a problem hiding this comment.
I'm trying to do this. Looks like we have collision with multiple definition of make_session from collections.
I've removed string name from key, but left struct.
| * | ||
| * @return session_id_t new unique id | ||
| */ | ||
| static session_id_t generate_uid(); |
There was a problem hiding this comment.
explicit naming for new id generation
| actor_zeta::send(dispatcher, | ||
| address(), | ||
| collection::handler_id(collection::route::create_index), | ||
| session, | ||
| session_id_t::generate_uid(), |
There was a problem hiding this comment.
Now it looks more self-documented
| @@ -36,14 +36,13 @@ class session_t { | |||
| ///components::session::session_id_t session_; | |||
| }; | |||
|
|
|||
| // TODO Remove this session and use logic from collections | |||
| // Move session logic from collections to a separate place | |||
| struct session_key_t { | |||
There was a problem hiding this comment.
Left structure with only one filed - not a great idea, but otherwise I have to do some general session refactoring.
@kotbegemot
| @@ -257,10 +257,13 @@ namespace services::disk { | |||
| auto indexes = read_indexes_(); | |||
| metafile_indexes_->seek_eof(); | |||
| for (const auto& index : indexes) { | |||
| trace(log_, "manager_disk: load_indexes_ : {}", index.name()); | |||
| // Require to separate sessions for load and create index | |||
There was a problem hiding this comment.
@kotbegemot left comment as you proceed.
|
@kotbegemot Can I merge it? |
- Session in dispather now use only session_id_t - Small switch-case refactor - In manager_disk we generate new session key for each call of create index
SergeiNA
force-pushed
the
sn.remove-find_session-with-name
branch
from
89f29dc
to
23e7107
Compare
Removing string name field from session_key in dispatcher session.
Because of further refactoring require remove name usage in create/drop_index from dispatcher -> require session changes.