Merge pull request #5 from Sebring/patch-1

docs: move io event handler to app.ready
ducktors · Jan 11, 2021 · 5acba86 · 5acba86
2 parents 56b7a33 + e68876a
commit 5acba86
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 4 deletions.
diff --git a/examples/basic/server.js b/examples/basic/server.js
@@ -8,11 +8,15 @@ const app = fastify({ logger: true })
 app.register(socketio)
 
 app.get('/', async (req, reply) => {
-  app.io.on('connect', () => console.info('Socket connected!'))
-
   const data = await readFile(join(__dirname, '..', 'index.html'))
   reply.header('content-type', 'text/html; charset=utf-8')
   reply.send(data)
 })
 
+app.ready(err => {
+  if (err) throw err
+
+  app.io.on('connect', (socket) => console.info('Socket connected!', socket.id))
+})
+
 app.listen(3000)
diff --git a/examples/typescript/server.ts b/examples/typescript/server.ts
@@ -8,11 +8,15 @@ const app = fastify({ logger: true })
 app.register(socketioServer)
 
 app.get('/', async (req, reply) => {
-  app.io.on('connect', () => console.info('Socket connected!'))
-
   const data = await readFile(join(__dirname, '..', 'index.html'))
   reply.header('content-type', 'text/html; charset=utf-8')
   reply.send(data)
 })
 
+app.ready(err => {
+  if (err) throw err
+
+  app.io.on('connect', (socket) => console.info('Socket connected!', socket.id))
+})
+
 app.listen(3000)