Add a language header to non-English feature files #17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ignore the .idea folder, used by IntelliJ IDEs like PyCharm. Some of it can be stored in version control, but it is probably best to leave editor settings to individual developers.
|
Will try and figure out the reason for these failures tomorrow. |
rayjolt
force-pushed
the
language-header
branch
2 times, most recently
from
5841da3
to
0044105
Compare
|
@rayjolt I have fixed the issue with Codacy. Could you add a test to cover the case there is no feature in the file? |
Language headers are necessary for non-English feature files, as without them the non-English keywords are not recognised as keywords. Fixes ducminh-phan#15
rayjolt
force-pushed
the
language-header
branch
from
0044105
to
2c2f43c
Compare
|
Thanks for fixing the Codacy issue. I was staring at that for quite a while trying to figure out what was wrong. :P |
|
Everything seems good! Thank you for your contribution. I'm going to release v1.0.1 soon. |
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request adds language headers to non-English feature files. Fixes #15.