Replace deprecated attrs "cmp" argument #20
Conversation
|
It seems that the attrs MyPy stubs are picky about what overloads are allowed for attrib(). I'll see if I can find something that works. |
|
I've worked out the immediate reason for the failure - the "eq" parameter isn't included in the overrides listed in the error message. However, in the stub file for the version of attrs listed in poetry.lock - 19.3.0 - both the "eq" and "order" parameters are included. I guess pre-commit must somehow be using an older version of attrs, but I'm not sure exactly how that works. |
|
I just tried using the latest version of MyPy (0.750) locally, and that works fine. Just updating MyPy to 0.750 in .pre-commit-config.yaml doesn't work though. It must be the attrs stub file that is out of date, but I haven't worked out where MyPy is getting it from yet. |
The "cmp" argument was deprecated in attrs 19.2.0 in favour of "eq" (see the changelog at [1]), so switch to using "eq" and update the minimum required attrs version. We also need to update the attrs version that MyPy depends upon in the pre-commit config, so while we are at it update the other pre-commit package versions as well. [1] https://www.attrs.org/en/stable/changelog.html
rayjolt
force-pushed
the
attrs-cmp-warning
branch
from
ef3822f
to
153c899
Compare
|
Solved it by manually specifying the attrs version in the pre-commit config. |
ducminh-phan
force-pushed
the
attrs-cmp-warning
branch
from
522e708
to
5cb1e20
Compare
The "cmp" argument was deprecated in attrs 19.2.0 in favour of "eq" (see
the changelog at [1]), so switch to using "eq" and update the minimum
required attrs version.
At the moment, several deprecation warnings are displayed when running
the tests. This pull request fixes all of those warnings.
[1] https://www.attrs.org/en/stable/changelog.html